Comments inline….
> On Sep 15, 2017, at 10:25 AM, Jacob Barrett <jbarr...@pivotal.io> wrote:
>
> -1 to all, comments below.
>
>
>> On Sep 15, 2017, at 10:18 AM, Mark Hanson <mhan...@pivotal.io> wrote:
>>
>> So we have two approaches as their has been a veto on w_string, so it will
>> not be used.
>
> Who said anything about veto? Nobody has veto authority. I simply stated and
> opinion on the use of wstring based on my research in the past.
>
Ok, not vetoed.
>> Approach 1) std::string str = object.to_string();
> To remain consistent with the APIs use of camel case this should be
> toString();
>
Uh, yeah. Concept not code...
>
>> Approach 2) std::string str = std::to_string(object);
>
> Nobody countered my assertion that this is not legal to export into std names
> space.
>
class blobject
{
bool blobBool;
};
namespace std {
std::string to_String(blobject * blob)
{
return std::string("works");
}
}
int main() {
blobject * blob = new blobject();
std::string str = std::to_String(blob);
std::cout << "Hello, World! " << "value = " << str << std::endl;
return 0;
}
/Users/mhanson/CLionProjects/untitled1/cmake-build-debug/untitled1
Hello, World! value = works
Process finished with exit code 0
> -Jake
>
>
