Github user ameybarve15 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/609#discussion_r131056489
  
    --- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 ---
    @@ -85,8 +72,10 @@ public void execute(FunctionContext context) {
           }
     
         } else {
    -      throw new IllegalArgumentException(
    +      IllegalStateException illegalStateException = new 
IllegalStateException(
               "The AEQ does not exist for the index " + indexName + " region " 
+ region.getFullPath());
    +      logger.error(illegalStateException.getMessage());
    --- End diff --
    
    @jhuynh1 
    If we throw exception from WaitUntilFlushedFunction then executing side 
will not get a true or false.
    Unless we send the result explicitly using resultSender.lastResult(result);
    or other alternative is to send this exception using sendException() Api 
and executing side needs to handle this exception to return a boolean result 
for waitUntilFlushed.
    
    @upthewaterspout @dschneider-pivotal @bschuchardt - please correct me if I 
am wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to