----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/#review179303 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java Lines 1796 (patched) <https://reviews.apache.org/r/60513/#comment253950> The current code is good but I had one more idea. Why not have the "isSelector()" checks in setTLCommBuffer and releaseTLCommBuffer? You can implement them to have the first line: if (!isSelector()) return; That would allow you to get rid of your call if isSelector in TXSynchronizationCommand and your run method in TXSynchronizationRunnable would no longer need to do the null check. - Darrel Schneider On June 29, 2017, 11:39 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60513/ > ----------------------------------------------------------- > > (Updated June 29, 2017, 11:39 a.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-3147 > https://issues.apache.org/jira/browse/GEODE-3147 > > > Repository: geode > > > Description > ------- > > Set byte buffer for the threads that need to send reply to clients when > Max_Threads are set. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java > 35b0e75 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > 472af09 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommBufferPool.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java > ebc9dab > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java > b1b0cfb > > geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java > 51ef44a > > > Diff: https://reviews.apache.org/r/60513/diff/3/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
