----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/#review179198 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java Lines 223 (patched) <https://reviews.apache.org/r/60513/#comment253781> How about moving all these changes to TXSynchronizationRunnable? When you construct it give it the serverConnection and then it can have needTLCommBuffer and do the setTLCommBuffer and releaseCommBuffer. That way you do not need to make a bunch of changes to this class and it will be much easier to review. - Darrel Schneider On June 28, 2017, 11:58 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60513/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 11:58 a.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-3147 > https://issues.apache.org/jira/browse/GEODE-3147 > > > Repository: geode > > > Description > ------- > > Set byte buffer for the threads that need to send reply to clients when > Max_Threads are set. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java > b1b0cfb > > geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java > 51ef44a > > > Diff: https://reviews.apache.org/r/60513/diff/1/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
