----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/#review179216 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java Lines 42 (patched) <https://reviews.apache.org/r/60513/#comment253839> make "acceptor" final geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java Line 42 (original), 44 (patched) <https://reviews.apache.org/r/60513/#comment253842> I think it would be nice if you introduced a new interface named "CommBufferPool" that just has two methods on it (takeCommBuffer and releaseCommBuffer). Change AcceptorImpl to extend this new interface and change this constructor to take a CommBufferPool instead of an AcceptorImpl. geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java Line 145 (original), 145 (patched) <https://reviews.apache.org/r/60513/#comment253841> I think this would be easier to understand: AcceptorImpl acceptor = serverConnection.getAcceptor(); if (!acceptor.isSelector()) { acceptor = null; } new TXSynchronizationRunnable(beforeCompletion, acceptor); - Darrel Schneider On June 28, 2017, 5:20 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60513/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 5:20 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-3147 > https://issues.apache.org/jira/browse/GEODE-3147 > > > Repository: geode > > > Description > ------- > > Set byte buffer for the threads that need to send reply to clients when > Max_Threads are set. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java > 35b0e75 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java > b1b0cfb > > geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java > 51ef44a > > > Diff: https://reviews.apache.org/r/60513/diff/2/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
