----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59380/#review176638 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/internal/cache/ha/EventIdOptimizationDUnitTest.java Line 518 (original), 515 (patched) <https://reviews.apache.org/r/59380/#comment250008> Since you are no longer calling notify() you can also get rid of this synchronized statement. - Darrel Schneider On June 1, 2017, 9:48 a.m., Lynn Gallinat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59380/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 9:48 a.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Eric Shu. > > > Repository: geode > > > Description > ------- > > When a non-existing entry is removed using removeAll from PartitionedRegion > (need to verify this on replicated), the CacheListener's aftrerDestroy > callback method gets invoked. The afterDestroy should not be invoked for > entry which is not present. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRemoveAllOperation.java > e236f80 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > f581856 > > geode-core/src/test/java/org/apache/geode/cache/RemoveAllCacheListenerPeerRegressionTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/client/RemoveAllCacheListenerClientServerRegressionTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/EventIdOptimizationDUnitTest.java > e4db6b1 > > > Diff: https://reviews.apache.org/r/59380/diff/2/ > > > Testing > ------- > > New unit tests, precheckin in progress. > > > Thanks, > > Lynn Gallinat > >
