----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59380/#review175437 -----------------------------------------------------------
Ship it! The code looks good. In you review description you mention that the problem is on PRs and that you need to check replicates. But your unit tests do test replicates so I think you know if replicates had the problem or not. - Darrel Schneider On May 18, 2017, 2:18 p.m., Lynn Gallinat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59380/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 2:18 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Eric Shu. > > > Repository: geode > > > Description > ------- > > When a non-existing entry is removed using removeAll from PartitionedRegion > (need to verify this on replicated), the CacheListener's aftrerDestroy > callback method gets invoked. The afterDestroy should not be invoked for > entry which is not present. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRemoveAllOperation.java > 42bf10f > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 8e7ec68 > > geode-core/src/test/java/org/apache/geode/cache/RemoveAllCacheListenerPeerRegressionTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/client/RemoveAllCacheListenerClientServerRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59380/diff/1/ > > > Testing > ------- > > New unit tests, precheckin in progress. > > > Thanks, > > Lynn Gallinat > >
