----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59380/ -----------------------------------------------------------
(Updated June 1, 2017, 4:48 p.m.) Review request for geode, anilkumar gingade, Darrel Schneider, and Eric Shu. Changes ------- This update contains changes to EventIdOptimizationDUnitTest.java. It had a test that did a destroy on a non-existent key and waited forever for an afterDestroy event so it could validate event ids. Now that the product does not fire afterDestroy events on non-existent keys, this test hung. There are two changes. One makes the test fail after two minutes if an afterDestroy event does not occur rather than waiting forever. The other puts the keys in the region before doing the destroys. A new run of precheckin passed. Repository: geode Description ------- When a non-existing entry is removed using removeAll from PartitionedRegion (need to verify this on replicated), the CacheListener's aftrerDestroy callback method gets invoked. The afterDestroy should not be invoked for entry which is not present. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRemoveAllOperation.java e236f80 geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java f581856 geode-core/src/test/java/org/apache/geode/cache/RemoveAllCacheListenerPeerRegressionTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/cache/client/RemoveAllCacheListenerClientServerRegressionTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/cache/ha/EventIdOptimizationDUnitTest.java e4db6b1 Diff: https://reviews.apache.org/r/59380/diff/2/ Changes: https://reviews.apache.org/r/59380/diff/1-2/ Testing ------- New unit tests, precheckin in progress. Thanks, Lynn Gallinat
