[ 
https://issues.apache.org/jira/browse/GEODE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022236#comment-16022236
 ] 

ASF GitHub Bot commented on GEODE-2980:
---------------------------------------

GitHub user davinash opened a pull request:

    https://github.com/apache/geode/pull/529

    GEODE-2980: All the methods in an interface are implicitly public and 
abstract.

    All fields in the interface are implicitly public, static and final.
    Removing this from all the interface.
    Pre-checkin pass.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    - [X] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    Not required for this change
    
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    NA
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davinash/geode feature/GEODE-2980

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #529
    
----
commit 8e6fdeec35ab62b3913dab9292fefe604fa340ad
Author: Avinash <avin...@ampool.io>
Date:   2017-05-23T03:55:02Z

    All the methods in an interface are implicitly public and abstract.
    All fields in the interface are implicitly public, static and final.
    Removing this from all the interface.

----


> Code Cleanup : Remove redundant modifier from the Interface definition
> ----------------------------------------------------------------------
>
>                 Key: GEODE-2980
>                 URL: https://issues.apache.org/jira/browse/GEODE-2980
>             Project: Geode
>          Issue Type: Task
>            Reporter: Avinash Dongre
>            Assignee: Avinash Dongre
>
> All methods in an interface are implicitly {{public}} and {{abstract}}
> All fields in an interface are implicitly {{public}}, {{static}} and 
> {{final}}.
> We have almost in all the interface public modifier for all the methods in 
> the Interfaces, we should remove the same.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to