[ 
https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022222#comment-16022222
 ] 

ASF GitHub Bot commented on GEODE-2962:
---------------------------------------

Github user AkihiroKitada commented on a diff in the pull request:

    https://github.com/apache/geode/pull/525#discussion_r118150229
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 ---
    @@ -485,9 +485,14 @@ public Result compactDiskStore(
                   memberCompactInfo.clear();
                 }
                 String notExecutedMembers = 
CompactRequest.getNotExecutedMembers();
    +            if (notExecutedMembers != null && 
!notExecutedMembers.isEmpty()) {
    +              notExecutedMembers = "but was not send to " + 
notExecutedMembers;
    +            } else {
    +              notExecutedMembers = "all the members";
    --- End diff --
    
    Hello Darrel,
    
    I remove redundant log message according to your suggestion.


> Need more friendly locator's log message when executing "gfsh compact 
> disk-store" command
> -----------------------------------------------------------------------------------------
>
>                 Key: GEODE-2962
>                 URL: https://issues.apache.org/jira/browse/GEODE-2962
>             Project: Geode
>          Issue Type: Wish
>          Components: persistence
>            Reporter: Akihiro Kitada
>            Priority: Minor
>
> When executing "gfsh compact disk-store" command, then we currently see the 
> following kind of issue if the command is successfully executed for all the 
> target members.
> {noformat}
> compact disk-store "DEFAULT" message was scheduled to be sent to but was not 
> send to null
> {noformat}
> This message is not friendly to know what was going on.
> Need more friendly log message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to