[
https://issues.apache.org/jira/browse/GEODE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932800#comment-15932800
]
ASF GitHub Bot commented on GEODE-2657:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106927884
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
SafeConvertClassGeneric::SetAppDomainEnabled(appDomainEnable);
+ if (appDomainEnable)
+ {
+ // Register managed AppDomain context with unmanaged.
+ apache::geode::client::createAppDomainContext =
&Apache::Geode::Client::createAppDomainContext;
--- End diff --
No, it just looked better here since the surrounding code was doing things
with the appDomainEnabled flag. Where it came from had no other AppDomain code
and didn't check the flag so it was always "enabled". Now it will be enable
only when the `appdomain-enabled` property is set.
> Execute Region Function sends incorrect message format
> ------------------------------------------------------
>
> Key: GEODE-2657
> URL: https://issues.apache.org/jira/browse/GEODE-2657
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: David Kimura
> Assignee: Jacob S. Barrett
>
> `TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`.
> This causes the message response to be parsed synchronously and not
> asynchronously chunked. The synchronous parser does not support this message
> type and it barfs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
