[ 
https://issues.apache.org/jira/browse/GEODE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932736#comment-15932736
 ] 

ASF GitHub Bot commented on GEODE-2657:
---------------------------------------

GitHub user pivotal-jbarrett opened a pull request:

    https://github.com/apache/geode-native/pull/63

    GEODE-2657

    Please make a quick review.
    
    Fixes all the integration tests around Function Execution and adds test of 
AppDomain Function Execution.
    
    Test testThinClientPoolExecuteFunctionDisableChunkHandlerThread is split 
out of testThinClientPoolExecuteFunction and marked OMITTED until GEODE-2691 is 
addressed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-2657

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode-native/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #63
    
----
commit a0bc51ae1026097f525b99c0141c6eb73b3f5714
Author: Jacob Barrett <jbarr...@pivotal.io>
Date:   2017-03-17T23:38:32Z

    GEODE-2657: Fixes and tests Function Execution.
    
    - Corrects message formatting.
    - Fixes integration tests.

commit cb02af7ec480ec6a46ea1c6fefc16f1697b33bf3
Author: Jacob Barrett <jbarr...@pivotal.io>
Date:   2017-03-16T13:36:32Z

    GEODE-2657: Fixes .NET test ThinClientFunctionExecutionTests.
    
    - Timeout is ms.

commit 9869b783c56119fa30f3e6712180a52e2398d52d
Author: Jacob Barrett <jbarr...@pivotal.io>
Date:   2017-03-18T00:21:20Z

    GEODE-2657: Tests Function Execution with AppDomains.

----


> Execute Region Function sends incorrect message format
> ------------------------------------------------------
>
>                 Key: GEODE-2657
>                 URL: https://issues.apache.org/jira/browse/GEODE-2657
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: David Kimura
>            Assignee: Jacob S. Barrett
>
> `TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`. 
> This causes the message response to be parsed synchronously and not 
> asynchronously chunked. The synchronous parser does not support this message 
> type and it barfs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to