[
https://issues.apache.org/jira/browse/GEODE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932790#comment-15932790
]
ASF GitHub Bot commented on GEODE-2657:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106927339
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTest2)
LOGINFO("FETimeOut begin onRegion");
ExecutionPtr RexecutionPtr = FunctionService::onRegion(regPtr0);
CacheableVectorPtr fe =
- RexecutionPtr->withArgs(CacheableInt32::create(5000))
+ RexecutionPtr->withArgs(CacheableInt32::create(5000 * 1000))
--- End diff --
Yes. Ultimately we should consider removing the continuity issue between
the client API and the server. The client is taking the timeout as seconds but
sending to the server as milliseconds. Ultimately taking a chrono::duration
would make the API more clear. The test would still need to be very explicit on
the use of milliseconds are the argument to the function.
> Execute Region Function sends incorrect message format
> ------------------------------------------------------
>
> Key: GEODE-2657
> URL: https://issues.apache.org/jira/browse/GEODE-2657
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: David Kimura
> Assignee: Jacob S. Barrett
>
> `TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`.
> This causes the message response to be parsed synchronously and not
> asynchronously chunked. The synchronous parser does not support this message
> type and it barfs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
