[
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876367#comment-15876367
]
ASF GitHub Bot commented on GEODE-2508:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/19#discussion_r102271148
--- Diff: src/cppcache/integration-test/CMakeLists.txt ---
@@ -21,7 +21,7 @@ target_link_libraries(${TEST_UTILS_LIB}
PRIVATE
ACE
PUBLIC
- apache-geode
+ ${PRODUCT_LIB_NAME}
--- End diff --
Rather than changing the target name of the library throughout CMake by
using a variable I suggest just controlling the output name of the binary using
the OUTPUT_NAME property.
set_target_properties(apache-geode PROPERTIES OUTPUT_NAME
${PRODUCT_LIB_NAME})
This way the target stays "apache-geode" but the results of the output will
be adjusted.
> Generize lib naming
> -------------------
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> Make naming configurable
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
