> On Jan. 6, 2017, 4 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/pdx/internal/PdxReaderImpl.java, > > lines 881-885 > > <https://reviews.apache.org/r/55236/diff/1/?file=1597914#file1597914line881> > > > > How does this affect the "rest" of the system and the processing of > > PDX? Have we now impacted performance?
This should be fine. > On Jan. 6, 2017, 4 p.m., Udo Kohlmeyer wrote: > > geode-core/src/test/java/org/apache/geode/pdx/JSONFormatterJUnitTest.java, > > line 266 > > <https://reviews.apache.org/r/55236/diff/1/?file=1597917#file1597917line266> > > > > Maybe we need a test that confirms that we will only generate 2 type > > definitions. One where the field exists and one where the field does not > > exist That the way pdx works. But I added null check test as well - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55236/#review160723 ----------------------------------------------------------- On Jan. 6, 2017, 7:30 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55236/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 7:30 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > GEODE-2271 JSOnFormatter can generate three pdxTypeId for one json field. > > JSON field can have 3 values(fieldValue, NULL, fieldNotExist), this > causes 3 pdxTypeIds. To reuduce this we merged first two values in > one pdxType. > > Added unit test for it > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java ff2ce04 > geode-core/src/main/java/org/apache/geode/pdx/internal/PdxReaderImpl.java > 4ebc33d > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java > e957cd6 > geode-core/src/test/java/org/apache/geode/pdx/Employee.java cfb46b5 > geode-core/src/test/java/org/apache/geode/pdx/JSONFormatterJUnitTest.java > 979da13 > geode-core/src/test/java/org/apache/geode/pdx/PdxStringJUnitTest.java > c072e14 > > geode-core/src/test/java/org/apache/geode/pdx/TestObjectForJSONFormatter.java > ca0abc3 > > Diff: https://reviews.apache.org/r/55236/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
