Review Request 55236: GEODE-2271 Reduce pdx type id generation for string fields in JSON

Thu, 05 Jan 2017 15:15:18 -0800 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55236/
-----------------------------------------------------------

Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.


Repository: geode


Description
-------

GEODE-2271 JSOnFormatter can generate three pdxTypeId for one json field.

    JSON field can have 3 values(fieldValue, NULL, fieldNotExist), this
    causes 3 pdxTypeIds. To reuduce this we merged first two values in 
    one pdxType.

    Added unit test for it


Diffs
-----

  geode-core/src/main/java/org/apache/geode/pdx/internal/PdxReaderImpl.java 
4ebc33d 
  
geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java
 e957cd6 
  geode-core/src/test/java/org/apache/geode/pdx/Employee.java cfb46b5 
  geode-core/src/test/java/org/apache/geode/pdx/JSONFormatterJUnitTest.java 
979da13 
  geode-core/src/test/java/org/apache/geode/pdx/PdxStringJUnitTest.java c072e14 
  geode-core/src/test/java/org/apache/geode/pdx/TestObjectForJSONFormatter.java 
ca0abc3 

Diff: https://reviews.apache.org/r/55236/diff/


Testing
-------


Thanks,

Hitesh Khamesra

Reply via email to