----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55236/#review160769 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/pdx/internal/PdxReaderImpl.java (line 906) <https://reviews.apache.org/r/55236/#comment231974> It looks like this creates a PdxString if the field is NULL or NULL_STRING. Is that the correct thing to do? I would think that DSCODE_NULL, at least, would return a null. geode-core/src/test/java/org/apache/geode/pdx/JSONFormatterJUnitTest.java (line 159) <https://reviews.apache.org/r/55236/#comment231982> Use an assertion: assertEquals(PdxInstance.class, receivedObject.getClass()); geode-core/src/test/java/org/apache/geode/pdx/JSONFormatterJUnitTest.java (line 178) <https://reviews.apache.org/r/55236/#comment231981> How about using assertions instead of these if/else statements? The if/else doesn't give you as much information about a failure as an assertion. assertEquals(TestObjectForJSONFormatter.class, actualTestObject.getClass()); assertEquals(expectedTestObject, actualTestObject); - Bruce Schuchardt On Jan. 6, 2017, 7:30 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55236/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 7:30 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > GEODE-2271 JSOnFormatter can generate three pdxTypeId for one json field. > > JSON field can have 3 values(fieldValue, NULL, fieldNotExist), this > causes 3 pdxTypeIds. To reuduce this we merged first two values in > one pdxType. > > Added unit test for it > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java ff2ce04 > geode-core/src/main/java/org/apache/geode/pdx/internal/PdxReaderImpl.java > 4ebc33d > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java > e957cd6 > geode-core/src/test/java/org/apache/geode/pdx/Employee.java cfb46b5 > geode-core/src/test/java/org/apache/geode/pdx/JSONFormatterJUnitTest.java > 979da13 > geode-core/src/test/java/org/apache/geode/pdx/PdxStringJUnitTest.java > c072e14 > > geode-core/src/test/java/org/apache/geode/pdx/TestObjectForJSONFormatter.java > ca0abc3 > > Diff: https://reviews.apache.org/r/55236/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
