[
https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762173#comment-15762173
]
ASF GitHub Bot commented on GEODE-2188:
---------------------------------------
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/316
let's keep the example package to contain only examples.
On Mon, Dec 19, 2016 at 12:09 PM, Kevin Duling <notificati...@github.com>
wrote:
> *@kjduling* commented on this pull request.
> ------------------------------
>
> In geode-core/src/main/java/org/apache/geode/examples/security/
> ExampleSecurityManager.java <https://github.com/apache/geode/pull/316>:
>
> > List<ResourcePermission> permissions = new ArrayList<>();
> +
>
> Originally, yes, they were in the same package. Then, after
> SampleSecurityManager was moved to ExampleSecurityManager and
> TestSecurityManger, the test was testing TestSecurityManager, which is
> silly. A test to test a test? By changing the test to point to
> ExampleSecurityManager, scope became an issue.
>
> We could also just move the test to the same package as the example and
> remove the accessors and public scope on the inner classes. Either is fine
> with me.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/316>, or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AO6fkmr1fpyCEz1IHZKAP1JDdo2We37Oks5rJuR2gaJpZM4LNb_H>
> .
>
--
Cheers
Jinmei
> ExampleSecurityManager references SampleSecurityManager in javadoc
> ------------------------------------------------------------------
>
> Key: GEODE-2188
> URL: https://issues.apache.org/jira/browse/GEODE-2188
> Project: Geode
> Issue Type: Bug
> Components: core, docs
> Reporter: Kevin Duling
> Assignee: Kevin Duling
> Priority: Minor
> Fix For: 1.1.0
>
>
> Example code was moved in GEODE-2092, but some strings need to be updated.
> Javadoc references an incorrect path.
> {{@code security-manager =
> org.apache.geode.security.examples.SampleSecurityManager}}
> and several strings refer to SampleSecurityManager.
> E.g.,
> {code}
> if (!initializeFromJsonResource(jsonPropertyValue)) {
> throw new AuthenticationFailedException(
> "SampleSecurityManager: unable to find json resource \"" +
> jsonPropertyValue
> + "\" as specified by [" + SECURITY_JSON + "].");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
