[
https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762009#comment-15762009
]
ASF GitHub Bot commented on GEODE-2188:
---------------------------------------
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r93097202
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final Map<String, User>
rolesToUsers, final JsonNode node
return roleMap;
}
- static class Role {
+ public static class Role {
List<ResourcePermission> permissions = new ArrayList<>();
+
--- End diff --
why was it working before? Was it because it was in the same package? If
your test code is testing ExampleSecurityManager, then better just leave it
public and have the getter/setters there.
> ExampleSecurityManager references SampleSecurityManager in javadoc
> ------------------------------------------------------------------
>
> Key: GEODE-2188
> URL: https://issues.apache.org/jira/browse/GEODE-2188
> Project: Geode
> Issue Type: Bug
> Components: core, docs
> Reporter: Kevin Duling
> Assignee: Kevin Duling
> Priority: Minor
> Fix For: 1.1.0
>
>
> Example code was moved in GEODE-2092, but some strings need to be updated.
> Javadoc references an incorrect path.
> {{@code security-manager =
> org.apache.geode.security.examples.SampleSecurityManager}}
> and several strings refer to SampleSecurityManager.
> E.g.,
> {code}
> if (!initializeFromJsonResource(jsonPropertyValue)) {
> throw new AuthenticationFailedException(
> "SampleSecurityManager: unable to find json resource \"" +
> jsonPropertyValue
> + "\" as specified by [" + SECURITY_JSON + "].");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
