> -----Original Message-----
> From: Ferruh Yigit <[email protected]>
> Sent: Thursday, February 3, 2022 9:36 PM
> To: Jerin Jacob Kollanukkaran <[email protected]>; [email protected]; Xiaoyun
> Li <[email protected]>; Aman Singh <[email protected]>;
> Yuying Zhang <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Devendra Singh Rawat
> <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Harman Kalra
> <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]; Igor
> Russkikh <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Kiran Kumar Kokkilagadda
> <[email protected]>; [email protected]; Liron Himi
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Pradeep Kumar Nalla <[email protected]>; Nithin Kumar Dabilpuram
> <[email protected]>; [email protected];
> [email protected]; Radha Chintakuntla <[email protected]>;
> [email protected]; Rasesh Mody <[email protected]>;
> [email protected]; [email protected]; Satha Koteswara Rao
> Kottidi <[email protected]>; Shahed Shaikh
> <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Sunil Kumar Kori <[email protected]>;
> [email protected]; Veerasenareddy Burru <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [EXT] Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add queue based
> pfc CLI options
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 1/31/2022 6:08 PM, [email protected] wrote:
> > From: Sunil Kumar Kori <[email protected]>
> >
> > Patch adds command line options to configure queue based priority flow
> > control.
> >
> > - Syntax command is given as below:
> >
> > set pfc_queue_ctrl <port_id> rx <on|off> <tx_qid> <tx_tc> \
> >     tx <on|off> <rx_qid> <rx_tc> <pause_time>
> >
> 
> Ahh I see the order is related to the configure struct, where tx_qid is part 
> of
> rx_pause struct.
> Can you please explaing this items selection in the struct?
> Most probaly it will clarify the above usage.
> 
Ack.

> > - Example command to configure queue based priority flow control
> >    on rx and tx side for port 0, Rx queue 0, Tx queue 0 with pause
> >    time 2047
> >
> > testpmd> set pfc_queue_ctrl 0 rx on 0 0 tx on 0 0 2047
> >
> > Signed-off-by: Sunil Kumar Kori <[email protected]>
> 
> <...>
> 
> >
> > +set pfc_queue_ctrl
> > +~~~~~~~~~~~~~~~~~~
> > +
> > +Set the priority flow control parameter on a given Rx and Tx queue of a
> port::
> > +
> > +   testpmd> set pfc_queue_ctrl <port_id> rx (on|off) <tx_qid> <tx_tc> \
> > +            tx (on|off) <rx_qid> <rx_tc> <pause_time>
> > +
> > +Where:
> > +
> > +* ``tx_qid`` (integer): Tx qid for which ``tx_tc`` will be applied
> > +and traffic
> > +  will be paused when PFC frame is received with ``tx_tc`` enabled.
> > +
> > +* ``tx_tc`` (0-15): TC for which traffic is to be paused for xmit.
> > +
> > +* ``rx_qid`` (integer): Rx qid for which threshold will be applied
> > +and PFC
> > +  frame will be generated with ``tx_tc`` when exceeds the threshold.
> > +
> > +* ``rx_tc`` (0-15): TC filled in PFC frame for which remote Tx is to be
> paused.
> > +
> > +* ``pause_time`` (integer): Pause quota filled in the PFC frame.
> > +
> 
> 'pause_time' is related to the TX pause configuration, right? At least in the
> config struct it only exists for Tx. If so can you please document this?
>
Ack.
 

Reply via email to