On 1/27/2022 7:13 AM, Sunil Kumar Kori wrote:
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Tuesday, January 25, 2022 11:07 PM
To: Jerin Jacob Kollanukkaran <[email protected]>; [email protected]; Xiaoyun
Li <[email protected]>; Aman Singh <[email protected]>; Yuying
Zhang <[email protected]>
Cc: [email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; Devendra Singh Rawat
<[email protected]>; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; Harman Kalra
<[email protected]>; [email protected];
[email protected]; [email protected]; [email protected]; Igor
Russkikh <[email protected]>; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected];
Kiran Kumar Kokkilagadda <[email protected]>;
[email protected]; Liron Himi <[email protected]>;
[email protected]; [email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; [email protected];
Pradeep Kumar Nalla <[email protected]>; Nithin Kumar Dabilpuram
<[email protected]>; [email protected]; [email protected];
Radha Chintakuntla <[email protected]>; [email protected];
Rasesh Mody <[email protected]>; [email protected];
[email protected]; Satha Koteswara Rao Kottidi
<[email protected]>; Shahed Shaikh <[email protected]>;
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; Sunil Kumar Kori
<[email protected]>; [email protected]; Veerasenareddy Burru
<[email protected]>; [email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]
Subject: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based
pfc CLI options
External Email
----------------------------------------------------------------------
On 1/13/2022 10:27 AM, [email protected] wrote:
From: Sunil Kumar Kori <[email protected]>
Patch adds command line options to configure queue based priority flow
control.
- Syntax command is given as below:
set pfc_queue_ctrl <port_id> rx <on|off> <tx_qid> <tx_tc> \
tx <on|off> <rx_qid> <rx_tc> <pause_time>
Isn't the order of the paramters odd, it is mixing Rx/Tx config, what about
ordering Rx and Tx paramters?
It's been kept like this to portray config for rx_pause and tx_pause separately
i.e. mode and corresponding config.
What do you mean 'separately'? You need to provide all arguments anyway, right?
I was thinking first have the Rx arguments, later Tx, like:
rx <on|off> <rx_qid> <rx_tc> tx <on|off> <tx_qid> <tx_tc> <pause_time>
Am I missing something, is there a benefit of what you did in this patch?
- Example command to configure queue based priority flow control
on rx and tx side for port 0, Rx queue 0, Tx queue 0 with pause
time 2047
testpmd> set pfc_queue_ctrl 0 rx on 0 0 tx on 0 0 2047
Signed-off-by: Sunil Kumar Kori <[email protected]>
<...>
