On 02/21/2016 02:02 AM, Boris Zbarsky wrote:
On 2/20/16 5:10 PM, Josh Matthews wrote:
(as a random comment, I never read multiline comments for Gecko. Only the
first line + the bug number. It is the bug where the relevant information
needs to be available. Whether it it available also elsewhere is less
important, IMHO.)
Having the info in a bug is nice, but having to read 30, or 150, or 500 bug
comments to find it can be less nice...
I think Gecko tends to rely to much on the "it's in the bug" crutch and not put
enough info into the commit message, personally.
-Boris
Well, even long commit messages tend to not capture all the key pieces why
certain change was made, and what it is supposed to do, and
often it is the comments from the reviewer which are valuable, and links to
other related bugs, dependency tracking etc.
But I know this is all very subjective. Some people like commit messages and
some prefer to read the bug.
Perhaps I had different opinion if Gecko had always used more descriptive
commit messages.
-Olli
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
