On Tue, Apr 21, 2015 at 8:39 AM, <jmath...@mozilla.com> wrote: > On Tuesday, April 21, 2015 at 3:03:37 AM UTC-5, Gabriele Svelto wrote: > > On 21/04/2015 08:25, Gabor Krizsanits wrote: > > > Maybe because I usually work on core, and such confidence is hard to > reach > > > there, but I'd like to think at least a try run that check if the patch > > > builds on all platform and a full test run on at least one platform is > not > > > too much sacrifice of ones time. > > > > > > Personally I think that "my time" is cheaper than "everyone's time". > It is > > > slow. It is annoying, but holding up ALL the other patches/developers > is > > > expensive hence a risky option. So I suggest everyone to be very > > > conservative about that confident feeling. > > > > I agree; since I work mostly on patches that are relevant for FxOS/B2G I > > always run a try build across all architectures before to ensure it > > doesn't break anything else. Somehow I was under the impression that > > everybody did that. > > > > Gabriele > > I think this should be standard procedure for anyone working on platform. > A push to try for a base set of builds (mac, linux, win, b2g ics) plus a > good set of tests (usually for me it's mochitests) covers things. Once > those mostly complete I can mark the bug with check-needed and walk away, > tree drivers will handle the landing when inbound is open and green.
Isn't the point of inbound supposed to be that it's safe to land even without 100% confidence? Here's the guidance from the Wiki: https://wiki.mozilla.org/Tree_Rules/Inbound Integration repositories are no replacement for Try. You still need to test your patches before pushing. (This doesn't mean that you need an all-platforms try run for every patch. But it does mean that you should do enough testing so that you rarely cause red or orange on the integration repository. But breaking it rarely is ok. Never missing a plane means you're spending too much time in airports; never breaking the tree means you're running too many tests before landing.) -Ekr _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
