So, I'm realizing that the vast majority of CFLAGS and CXXFLAGS variables in Makefile.in's are after a config.mk/rules.mk include, and for now I'm not touching them. Help wanted on moving those ones to moz.build because I'm not sure what I should be watching out for.
(Also, the vast majority of those variables just add things like TK_CFLAGS that do not exist in moz.build. I'm ignoring those as well.) -- Ehsan <http://ehsanakhgari.org/> On Sun, Feb 16, 2014 at 10:08 PM, Gregory Szorc <g...@mozilla.com> wrote: > On 2/16/2014 6:07 PM, Ehsan Akhgari wrote: > > What is the plan for porting CFLAGS and friends to moz.build? Is there > > any work in progress for that? How can one help? > > There is the potential for weird interactions between config.mk and > CFLAGS and friends, which is the primary reason we held off porting it. > I /think/ most of those concerns went away when we included backend.mk > in config.mk rather than in rules.mk. But keep in mind there's still the > potential for reordering issues: because of how variable assignment > works in make and how variable evaluation is performed in rules.mk, if a > variable change *after* "include rules.mk" in a Makefile.mk is moved to > a moz.build, that may change behavior. CFLAGS manipulation before > "include config.mk" or "include rules.mk" should be safe to move to > moz.build. Exercise extreme discretion if CFLAGS and friends are > manipulated after including config.mk or rules.mk. > >
_______________________________________________ dev-builds mailing list dev-builds@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-builds
