Hi Helge, Le 20/11/2011 14:25, Helge Kreutzmann a écrit (message #57) :
> as requested, the diff is attached. Thanks for everything, I just tried to address your last five reviews in that message (no need to CC me , I read the po4a bug reports). Just a few notes: > -In this example we assume that your generated man pages (and all PO and add > +In this example we assume that your generated man pages (and all PO and > addendum > files) It's actually “addenda” (plural form). > -They take in argument a coma separated list of macros. > +They take as argument a comma separated list of macros. I fixed a few other occurrences and consistently added an hyphen between “comma” and “separated”, ditto for s/in argument/as argument/. > -Complete list of pages having this problem on my box (from 564 pages ; note > +Complete list of pages having this problem on my box (from 564 pages; note Similar issues fixed in TransTractor.pm. > Additionally, the following issues are unclear to me: > > po4a:500 > This string has explicit line breaks in the pot file (\n) but I cannot > see anything special in the original file. See “-rm -rf man/translated”. > E.g. po4a:518 > The order of the SEE ALSO entries is not according to the man page > specification, which says to order by section and within a section by > alphabet. However, I assume this different order is on purpose? I don't know if the order is in purpose (it seems so), but please note that man-pages(7) (if that's the document you're referring to) documents the man pages of the *Linux man-pages project*, and po4a is not part of it. I recently fixed the order of dctrl-tools pages after Chris Leick pointed me to that doc in #651219, but would prefer not to take action on other manual pages until Colin Watson replies to #651482. > doc/po4a-build.conf.5.pod:139 > I do not fully understand why this paragraph ends in a colon and why > there is no language prefix in the example following (as I understood, > the documents are the translated ones, right?) I have no clue about po4a-build, explicitly CCing Neil this time since he didn't respond to the message #32 of this BR either. > lib/Locale/Po4a/Sgml.pm:150 > I would do a s/valid/invalid/, however, I might not understand the > content 100%. Not sure either, but anyway, this module is mostly useful for DebianDoc, and I'd prefer help moving the remaining DebianDoc stuff to DocBook XML than digging into this module ;-). Anyway, changes applied in r2516. Le 28/11/2011 10:24, Helge Kreutzmann a écrit (message #62) : > --- lib/Locale/Po4a/Po.pm (Revision 2505) > +++ lib/Locale/Po4a/Po.pm (Arbeitskopie) > @@ -44,7 +44,7 @@ > This module is part of the PO4A project, which objective is to use PO files > (designed at origin to ease the translation of program messages) to > translate everything, including documentation (man page, info manual), > -package description, debconf templates, and everything which may benefit > +package descriptions, debconf templates, and everything which may benefit > from this. I didn't take this one, since one package may only have one description, but maybe am I missing something. I fixed the uppercase of po4a anyway, and applied your other proposals in r2517. Le 09/12/2011 16:34, Helge Kreutzmann a écrit (message #67) : > +# FIXME: A better (more precise) link should be given here > #. type: textblock > #: lib/Locale/Po4a/Po.pm:41 Feel free to propose one, that could be added to a new SEE ALSO section for example. > -to check that the update is needed (this avoids to change a POT just to > +to check if the update is needed (this avoids to change a POT just to Applied in r2518. Le 18/12/2011 12:26, Helge Kreutzmann a écrit (message #72) : Applied in r2519. Le 27/12/2011 16:03, Helge Kreutzmann a écrit (message #77) : Also applied, in r2520, thanks again. I took care of trivial unfuzzy when possible, e.g. only three fuzzy strings in your PO file. Regards David
signature.asc
Description: OpenPGP digital signature
