On Wed, 14 Apr 2010, Soeren Sonnenburg wrote:
> > > one basically would need to build libshogun{,ui} first and then using
> > > this libshogun{,ui} build the other interfaces with various settings.
> > > quite a bit of effort I currently don't have time for... 
> there is more needed for this, I tried to add the correct SO prefix for
> python debug in shogun-trunk. could you please give it a try and tell me
> if python-dbg works with shogun in this case?
ok -- 2nd drop from my side (see attached patch).

It allows (and switches to for noopt) to build with -O0 (blocked
for python2.5 by #577826 if I was right ;) but with -O2 I guess should
build fine for 2.5, didn't thoroughly checked yet), reverts win32 specific
handling.

current problem is following:

$> ls -ld ../install*/lib/python2.6/*/shogun/_Class*so         
-rwxr-xr-x 1 yoh yoh 2783247 Apr 14 21:01 
../install-dbg/lib/python2.6/dist-packages/shogun/_Classifier._d.so*
-rwxr-xr-x 1 yoh yoh 2778444 Apr 14 21:29 
../install/lib/python2.6/dist-packages/shogun/_Classifier..so*

so, before all those EXT_LIB relied on keeping just an extension after a
period... now it is more inline with EXT_SRC_SWIG EXT_IF_SWIG which did have a
period.  So, I guess, it would require major unification of what is kept in
EXT_* variables to make it uniform across all...

P.S. it is sad that there is no way in SVN to preserve the author of the
commit... or should I commit such simple patches directly to SVN?

-- 
                                  .-.
=------------------------------   /v\  ----------------------------=
Keep in touch                    // \\     (yoh@|www.)onerussian.com
Yaroslav Halchenko              /(   )\               ICQ#: 60653192
                   Linux User    ^^-^^    [175555]


From 1aa8122cd694b324e6c9f24b4e94fd1fafeab31c Mon Sep 17 00:00:00 2001
From: Yaroslav Halchenko <deb...@onerussian.com>
Date: Wed, 14 Apr 2010 21:25:10 -0400
Subject: [PATCH] switch to -O0 for NOOPTS, revert to win32-specific use of _pylibpath, rely on EXT_LIB_SWIG_PYTHON_MODULAR for PYTHON_TARGET

---
 src/configure |   18 ++++++++----------
 1 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/configure b/src/configure
index 6fecc3d..cdca3fa 100755
--- a/src/configure
+++ b/src/configure
@@ -129,7 +129,7 @@ CONFIGURE_OPTIONS="configure options $@"
 GDB=gdb
 MAKE=make
 COMP_OPTS="-g -Wall -O9 -fexpensive-optimizations -frerun-cse-after-loop -fcse-follow-jumps -finline-functions -fschedule-insns2 -fthread-jumps -fforce-addr -fstrength-reduce -funroll-loops"
-COMP_NOOPTS="-g -Wall -O2"
+COMP_NOOPTS="-g -Wall -O0"
 COMPFLAGS_C=-fPIC
 COMPFLAGS_CPP=-fPIC
 SEDMI='sed -i'
@@ -3348,12 +3348,15 @@ test_python()
 			EXT_IF_SWIG_PYTHON_MODULAR='.py'
 			test -n "$_pyinclude" && _pyinclude="-I$_pyinclude"
 			test -n "$_pyinclude" || _pyinclude=`$PYTHON -c "from distutils.sysconfig import get_python_inc; import numpy; print '-I%s -I%s' % (get_python_inc(), numpy.get_include())"`
-			_pylibpath=`$PYTHON -c 'from distutils.sysconfig import get_config_vars; print "-L%(LIBPL)s" % get_config_vars()'`
-			test -n "$_pylibs" || _pylibs=`$PYTHON -c "import sys; print 'python'+sys.version[0:3]"`
+			if win32
+			then
+				_pylibpath=`$PYTHON -c 'from distutils.sysconfig import get_config_vars; print "-L%(LIBPL)s" % get_config_vars()'`
+			fi
+			EXT_LIB_SWIG_PYTHON_MODULAR=`$PYTHON -c 'from distutils.sysconfig import get_config_vars; print "%(SO)s" % get_config_vars()'`
+			test -n "$_pylibs" || _pylibs=`$PYTHON -c "import sys; print 'python'+sys.version[0:3]"`${EXT_LIB_SWIG_PYTHON_MODULAR%.*}
 			INCLUDES_PYTHON="$_pyinclude $INCLUDES_PYTHON"
 			COMPFLAGS_CPP_PYTHON="-fno-strict-aliasing -fPIC $COMPFLAGS_CPP_PYTHON"
 			COMPFLAGS_C_PYTHON="-fno-strict-aliasing -fPIC $COMPFLAGS_C_PYTHON"
-			EXT_LIB_SWIG_PYTHON_MODULAR=`$PYTHON -c 'from distutils.sysconfig import get_config_vars; print "%(SO)s" % get_config_vars()'`
 
 			if darwin
 			then
@@ -3364,12 +3367,7 @@ test_python()
 				POSTLINKFLAGS_PYTHON="-shared $_pylibpath -l$_pylibs $POSTLINKFLAGS_PYTHON"
 			fi
 
-			if win32
-			then
-				PYTHON_TARGET="sg.dll"
-			else
-				PYTHON_TARGET="sg.so"
-			fi
+			PYTHON_TARGET="sg$EXT_LIB_SWIG_PYTHON_MODULAR"
 
 cat > $TMPC << EOF
 #include <Python.h>
-- 
1.7.0.3

Attachment: signature.asc
Description: Digital signature

Reply via email to