Hi,
> So, dpatch-edit-patch produces horrid-looking diff headers:
>
> diff -urNad --exclude=CVS --exclude=.svn ./src/foo.h
> /tmp/dpep-work.XujkX1/foo-1.0/src/foo.h
> --- ./src/foo.h 1996-03-16 10:58:58.000000000 -0600
> +++ /tmp/dpep-work.XujkX1/foo-1.0/src/foo.h 2005-08-04
> 13:39:08.000000000 -0500
>
> These look bad, but also, the /tmp/dpep-work.XujkX1 changes every time
> dpatch-edit-patch runs. So diffing two versions of a patch produces
> lots of noise, for *every* file touched by the patch - even the files I
> did not modify this time. That noise also ends up in the cvs/svn
> commit.
I've also experienced this problem while creating dpatch testsuites,
so this part I do understand your needs and concerns;
however I am not extremely happy about the implementation details.
> I've attached 2 patches - the first is minimal, the second also
> includes a trivial cleanup I found hard to resist.
The first one looks fine to me, the second looks intrusive;
care to explain?
regards,
junichi
--
Junichi Uekawa, Debian Developer http://www.netfort.gr.jp/~dancer/
183A 70FC 4732 1B87 57A5 CE82 D837 7D4E E81E 55C1
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
