On Thu, Dec 25, 2008 at 10:32:45PM +0100, Nico Golde wrote: > * Diego Biurrun <di...@biurrun.de> [2008-12-25 22:19]: > > On Wed, Dec 24, 2008 at 11:12:34PM +0100, Nico Golde wrote: > > > * Diego Biurrun <di...@biurrun.de> [2008-12-24 22:50]: > > > > On Tue, Dec 23, 2008 at 09:56:15PM +0100, A Mennucc wrote: > [...] > > > > Your patch is incorrect and insufficient. You should submit your > > > > patches upstream to FFmpeg instead of posting it to a distro bug > > > > tracker. It was reviewed no more than 15 minutes (on a December > > > > 24) after I sent it to the ffmpeg-devel mailing list. > > > > > > > > Please do not add not fully understood patches to your distro packages. > > > > > > You do read the referenced bugs before starting to throw > > > with mud do you? > > > I guess not otherwise you would have read > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=509616#5: > > > "Attached is a patch to fix this, I am not sure if that is > > > the correct way to fix this as I have no insight on the code > > > functionality itself but at least it prevents mplayer from > > > crashing. So you might want to check back with upstream." > > > > And here is your upstream, confirming what you already suspected: Your > > patch papers over the problem without fixing the root cause. > > > > So if you knew this all along, why act offended now? > > Because I have better things to do than reading arrogant > upstream replies who fail to read the references but instead > act like people would blindly apply patches?
Sorry, but I have personally reviewed looked at about a dozen FFmpeg and MPlayer packages[1] and "blindly apply patches" was often enough an accurate description of my findings. Debian is no exception. Before Reinhard Tartler took over as FFmpeg packager about a dozen patches were being applied to FFmpeg by Debian. Thankfully Reinhard works much more closely with upstream (and me in particular) than his predecessors. I reviewed that dozen of patches. The end result was that >50% could be discarded, two or so were applied and another two or so I implemented better within FFmpeg. The next time Reinhard updates FFmpeg only one local patch will remain (IIRC). So you will have to forgive me if I step in when I see a patch being proposed for the FFmpeg package in Debian. It would not have been the first time that incomplete workarounds got applied. > > > > We all know the troubles this caused with openssl. > > > > > > What a miserable comparison. > > > > I beg to differ. It is not a distributions job to patch programs. > > There are hardly any exceptions to this rule. > > > > The openssl fiasco was just a very visible and catastrophic example. > > The root problem, however, is the same: Distributions patching programs > > without upstream coordination and review. > > I see no need to discuss this with you as you seem to miss > the necessary background, please consult your favorite > search engine. You know http://marc.info/?l=openssl-dev&m=114652287210110&w=2 > do you? I know. And the root cause of the problem was distros applying patches without fully understanding them. I do not see this issue resolved. This is not at all specific to Debian. Sooner or later something like this was bound to happen. It's just sheer bad luck that it hit Debian. It could have been any other Linux (or BSD) distro. The only way forward is closer cooperation with upstream. However, if you are going to get offended every time someone utters the term "openssl" your life as packager will be difficult. It's going to be cited for years as a bad example of where things can end... > > merry xmas > > same to you, let's start on fixing the bug. Working on it. I already proposed your patch and entered the issue into our project bug tracker so that it is not forgotten. I will let Reinhard know if/when a proper solution appears that he can backport. Diego [1] Note that I do not make a difference between Linux distributions and BSD flavors. From the upstream perspective they are just another packager. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
