On Wed, Dec 24, 2008 at 11:12:34PM +0100, Nico Golde wrote: > * Diego Biurrun <di...@biurrun.de> [2008-12-24 22:50]: > > On Tue, Dec 23, 2008 at 09:56:15PM +0100, A Mennucc wrote: > > > On Tue, Dec 23, 2008 at 09:21:44PM +0100, Nico Golde wrote: > > > > I tracked the ogm file issue down to ffmpeg, it's not an > > > > mplayer issue. I reported this as: #509616.. > > > > Your patch is incorrect and insufficient. You should submit your > > patches upstream to FFmpeg instead of posting it to a distro bug > > tracker. It was reviewed no more than 15 minutes (on a December > > 24) after I sent it to the ffmpeg-devel mailing list. > > > > Please do not add not fully understood patches to your distro packages. > > You do read the referenced bugs before starting to throw > with mud do you? > I guess not otherwise you would have read > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=509616#5: > "Attached is a patch to fix this, I am not sure if that is > the correct way to fix this as I have no insight on the code > functionality itself but at least it prevents mplayer from > crashing. So you might want to check back with upstream."
And here is your upstream, confirming what you already suspected: Your patch papers over the problem without fixing the root cause. So if you knew this all along, why act offended now? This is upstream appearing on your distribution channels and helping you out directly. > > We all know the troubles this caused with openssl. > > What a miserable comparison. I beg to differ. It is not a distributions job to patch programs. There are hardly any exceptions to this rule. The openssl fiasco was just a very visible and catastrophic example. The root problem, however, is the same: Distributions patching programs without upstream coordination and review. Unfortunately this mindset is entrenched in distro people's minds and changing your habits will be difficult. If the openssl fiasco leads to change in this area, it will end up having had a positive effect in the long run. merry xmas Diego -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
