Hi Ben, On Thu, 2025-07-10 at 19:35 +0000, Ben Westover wrote: > > - debian/patches/soversion.patch: As per the discussion at [1], > > should this be removed entirely or switched to minor version > > increments? > > I would prefer not to do this, as it would mean uploading to NEW very > often and I would need to get a DD to do that every time as I am a DM. > However I am willing to do this if it makes more sense for everyone.
It looks like upstream don't bump the minor version very often -- for instance, 10.0.x lasted from Feb 16, 2022 all the way to Feb 15, 2025. Having separate packages for each minor version would ensure that any packages that build-depend on dpp won't break after upstream's ABI- breaking changes (i.e. a package can depend on libdpp10.1 and will continue to build successfully even after the dpp package is updated to 10.2 and libdpp10.2 is introduced to the archive, as libdpp10.1 will remain for anything that needs it. If the package depends on libdpp10 instead, then when 10.2 comes around, it will be forced to build with the newer version with breaking changes, and potentially FTBFS.) > > - The docs from the libdpp-doc package are unusable; it looks like the > > formatting was lost somewhere. For instance, the logo covers the > > entire screen and I cannot access anything from the navigation bar. > > I just tested this, and it looks like it happens both with and without > my local CSS patch. So the upstream's local doc build support must be > broken in a big way; I'll look into it. Found the culprit! Upstream uses a git submodule for doxygen-awesome-css and refers to it in Doxyfile in HTML_EXTRA_STYLESHEET. doxygen-awesome- css is packaged in Debian, so changing the path to the stylesheet from the package should fix the issue. I've attached a patch for this. Would you like the Salsa repo moved to the debian/ group or would you prefer to keep it where it is? Thanks, Maytham > > >
From 2e21cf801cb534f906ae5bb797ae59c9555a811d Mon Sep 17 00:00:00 2001 From: Maytham Alsudany <mayt...@debian.org> Date: Fri, 11 Jul 2025 09:37:19 +0800 Subject: [PATCH] Use packaged doxygen-awesome-css --- debian/control | 1 + debian/patches/doc-use-packaged-css.patch | 16 ++++++++++++++++ debian/patches/series | 1 + 3 files changed, 18 insertions(+) create mode 100644 debian/patches/doc-use-packaged-css.patch diff --git a/debian/control b/debian/control index 392766f..e7eb7a9 100644 --- a/debian/control +++ b/debian/control @@ -6,6 +6,7 @@ Build-Depends: debhelper-compat (= 13), cmake, doxygen <!nodoc>, + doxygen-awesome-css <!nodoc>, graphviz <!nodoc>, libopus-dev, libssl-dev, diff --git a/debian/patches/doc-use-packaged-css.patch b/debian/patches/doc-use-packaged-css.patch new file mode 100644 index 0000000..8fb7e5d --- /dev/null +++ b/debian/patches/doc-use-packaged-css.patch @@ -0,0 +1,16 @@ +Description: Use the stylesheets from the doxygen-awesome-css package. +Author: Maytham Alsudany <mayt...@debian.org> +Forwarded: not-needed +Last-Update: 2025-07-11 + +--- a/Doxyfile ++++ b/Doxyfile +@@ -1082,7 +1082,7 @@ + # see the documentation. + # This tag requires that the tag GENERATE_HTML is set to YES. + +-HTML_EXTRA_STYLESHEET = doxygen-awesome-css/doxygen-awesome.css docpages/style.css ++HTML_EXTRA_STYLESHEET = /usr/share/doxygen-awesome-css/doxygen-awesome.css docpages/style.css + + # The HTML_EXTRA_FILES tag can be used to specify one or more extra images or + # other source files which should be copied to the HTML output directory. Note diff --git a/debian/patches/series b/debian/patches/series index 23ce862..4a5789c 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,3 +1,4 @@ external-json.patch soversion.patch doc-local-web-source.patch +doc-use-packaged-css.patch -- 2.50.0.714.g196bf9f422f
signature.asc
Description: This is a digitally signed message part
