Hi Ben, Your packaging looks good, just a few comments:
- debian/control: The source package and the binary package names don't
match; the source package uses "d++" whereas the binary package uses
"dpp". I reckon it would be better to choose one and stick with it.
- debian/patches/soversion.patch: As per the discussion at [1],
should this be removed entirely or switched to minor version
increments?
- The docs from the libdpp-doc package are unusable; it looks like the
formatting was lost somewhere. For instance, the logo covers the
entire screen and I cannot access anything from the navigation bar.
- debian/patches/doc-local-web-source.patch: Instead of removing the
YouTube video entirely, you can still provide a link to it.
- debian/control: This isn't mission critical, but the last line in the
descriptions of the -dev and -doc packages (This package contains...)
should be separated by a period (".") on its own line to avoid it
wrapping with the rest of the description.
- Your repo has both a debian/unstable and debian/master branch. You
should choose only one i.e. your "upload to unstable" commit should be
pushed straight to debian/master, having a separate branch for uploads
is not necessary.
- Since the trixie freeze is still ongoing, you'll want to target the
upload of this package to experimental to avoid interfering with the
new Debian release.
If you'd like to do so, you can add me (@Maytha8) as an owner to the
repository and I can move the Salsa repository from your personal
namespace to the shared debian/ namespace.
--
Maytham
signature.asc
Description: This is a digitally signed message part
