Hi Maytham, Thanks for the review.
On 7/8/25 9:31 AM, Maytham Alsudany wrote:
> - debian/control: The source package and the binary package names don't
> match; the source package uses "d++" whereas the binary package uses
> "dpp". I reckon it would be better to choose one and stick with it.
I did this because the name of the project is D++, but the actual lib
name is dpp because not every system plays nicely with the + character.
I suppose it would make sense to change the source package to "dpp"
since the binary packages also use this name, and it avoids confusion.
> - debian/patches/soversion.patch: As per the discussion at [1],
> should this be removed entirely or switched to minor version
> increments?
I would prefer not to do this, as it would mean uploading to NEW very
often and I would need to get a DD to do that every time as I am a DM.
However I am willing to do this if it makes more sense for everyone.
> - The docs from the libdpp-doc package are unusable; it looks like the
> formatting was lost somewhere. For instance, the logo covers the
> entire screen and I cannot access anything from the navigation bar.
I just tested this, and it looks like it happens both with and without
my local CSS patch. So the upstream's local doc build support must be
broken in a big way; I'll look into it.
> - debian/patches/doc-local-web-source.patch: Instead of removing the
> YouTube video entirely, you can still provide a link to it.
Done.
> - debian/control: This isn't mission critical, but the last line in the
> descriptions of the -dev and -doc packages (This package contains...)
> should be separated by a period (".") on its own line to avoid it
> wrapping with the rest of the description.
Done.
> - Your repo has both a debian/unstable and debian/master branch. You
> should choose only one i.e. your "upload to unstable" commit should be
> pushed straight to debian/master, having a separate branch for uploads
> is not necessary.
I don't like having "unstable" in my changelog on the master branch
unless the package is actually in unstable. But that's in the changelog
for my mentors upload so you can send it right to NEW without editing.
When this package actually is in unstable, that part will be in master.
> - Since the trixie freeze is still ongoing, you'll want to target the
> upload of this package to experimental to avoid interfering with the
> new Debian release.
As Mathias said, it doesn't matter since it still needs to go to NEW.
I have addressed these points in a new upload to mentors, which also has
a new minor version from upstream. Thanks again for the in-depth review!
--
Ben Westover
OpenPGP_signature.asc
Description: PGP signature
