Hi, Pascal Hambourg <pas...@plouf.fr.eu.org> wrote (Sun, 8 Sep 2024 11:53:28 +0200): > On 30/08/2024 at 13:32, Holger Wansing wrote: > >>>>> Am 27. August 2024 23:46:41 MESZ schrieb Pascal Hambourg > >>>>> <pas...@plouf.fr.eu.org>: > >>>>> > >>>>>>>> Looking at partman-auto-lvm code more closely, it seems that the > >>>>>>>> lvmok > >>>>>>>> flag check happens only after calling choose_recipe. So I guess the > >>>>>>>> check should be moved into choose_recipe (in partman-auto). > (...) > >>>> Patch ready and tested. Shall I add it to the MR or open a new one ? > (...) > > Ok, so I think we include it in this MR then. > > Patch included. I also updated existing recipes and added new server and > small_disk recipes for armhf, ppc64el and riscv64.
Fine. > I also wrote a crude script which generates recipe files for the 5 > architectures updated in this MR from a reduced set of parameters: > > <https://salsa.debian.org/pham/partman-auto/-/blob/recipe_generator/build_recipes?ref_type=heads> > > It does the tedious partition priority value calculations from simple > percentage-like values. With the current parameters, the generated files > are the same as in the current state of this MR (commit b3a0376f). It > allowed me to spot and fix a missing tag in some new recipes I created > manually. It comes in handy to test other size limits, and maybe it > could help generating recipe files on further updates. Cool! We should definetely include this into the package. Since you made a separate branch for this, feel free to create a new MR. Otherwise, we are still stuck on the 16MiB offset thingy. May I propose we push this out, as it is now? It's a big change already, and would warrant an upload in this state. As already mentioned by josch, we could then discuss the 16MiB issue separately. Holger -- Holger Wansing <hwans...@mailbox.org> PGP-Fingerprint: 496A C6E8 1442 4B34 8508 3529 59F1 87CA 156E B076
