Hi again, Am 27. August 2024 21:47:14 MESZ schrieb Pascal Hambourg <pas...@plouf.fr.eu.org>: >On 27/08/2024 at 12:42, Holger Wansing wrote: >> >> And I did some tests again; the results are at [2]. >> To give a short summary: the results are really really great !!! >> (I tested all default recipes). > >I wonder if / should not grow a bit faster (higher priority). > >Also, this caught my eye: ><https://people.debian.org/~holgerw/d-i__new-limits_and_fix-envelope-calculation/attempt_2/10G-disk__1G-RAM/use-entire-disk__separate-home-var-tmp.png> > >/home is smaller than the minimum size defined by the recipe. It should not >happen. I cannot even figure out how such a result is possible. The multi >recipe minimum disk size is 11GB so it should not have been available with a >10.7GB disk. I need to investigate.
Good catch! I also noticed some inconsistency here, but I did not mention it, considering it being a corner case: when entering the menu (use entire disk -> <disk identifier> ) the first time, the "separate home+tmp+var" choice was not provided, but in my tests I restarted the partitioning step multiple times, and so, when choosing "guided partioning" -> "use entire disk" -> <disk- identifier> once more again, it was surprisingly there! So I was able to choose this (unpossible) choice :-) > >> Just two small notes: >> - the text for the new small_disk recipe should be changed, it says >> it's for disks "< 1G" but I think you meant "< 10G". > >Actually I just forgot to update the existing description, good catch. I will >do it. > >> - when choosing "use LVM" the small_disk recipe is provided as choice, >> but it fails when I try it. >> Could it be changed, so it just works? >> (Not highest priority, but using LVM in such case of small disk would >> allow, to add another disk later and get rid of the "low diskspace" >> issue without reinstalling - at least when the machine hardware/housing >> allows to add one more disk). > >I did not consider this use case. Wouldn't it be simpler to use manual >partitioning ? Yes, for sure! I just wanted to save the installer-team from "the small_disk recipe does not work" bugreports :-) > >> Or otherwise the entry should be not visible. > >This was my initial intent. I removed the lvmok flag (and /boot) from the >small_disk recipe and expected it to be ignored when using LVM. Looking at >partman-auto-lvm code more closely, it seems that the lvmok flag check happens >only after calling choose_recipe. So I guess the check should be moved into >choose_recipe (in partman-auto). Ok. I would propose to move such change into a separate discussion/ bug report. Putting onto my to-do list. > >> BTW: I could not test the ESP part, since my test image cannot boot via EFI. >> My remastering somehow breaks the EFI boot capabilities... > >Indeed, the EFI partition/El Torito image is missing. A workaround it to >extract the EFI partition from the original image, copy it to an other >disk/image and boot from it. It should then find the CD. Ok. Maybe I can find time to do some more tests that way ... Holger -- Sent from /e/ OS on Fairphone3
