Hi, Am 30. August 2024 11:36:28 MESZ schrieb Pascal Hambourg <pas...@plouf.fr.eu.org>: >On 29/08/2024 at 22:12, Holger Wansing wrote: >> Am 29. August 2024 20:25:05 MESZ schrieb Pascal Hambourg >> <pas...@plouf.fr.eu.org>: >>> On 28/08/2024 at 18:43, Holger Wansing wrote: >>>> Am 27. August 2024 23:46:41 MESZ schrieb Pascal Hambourg >>>> <pas...@plouf.fr.eu.org>: >>>> >>>>>>> Looking at partman-auto-lvm code more closely, it seems that the lvmok >>>>>>> flag check happens only after calling choose_recipe. So I guess the >>>>>>> check should be moved into choose_recipe (in partman-auto). >>>>>> >>>>>> Ok. I would propose to move such change into a separate discussion/ >>>>>> bug report. Putting onto my to-do list. >>> >>> Patch ready and tested. Shall I add it to the MR or open a new one ? >> >> As I already wrote, I would like to keep that separate from this one. >> So, any problem with pushing this into a new MR? > >The problem is with reverting "Add LVM support to the small_disk recipe". If >the fix is added to this MR, then "Add LVM support to the small_disk recipe" >can be reverted right away. If the fix is included in another MR, then the >revert commit will depend on which architectures have the small_disk recipe at >the time of the merge (only default+EFI, or all). Unless you don't want to >revert it, of course (which makes the fix a bit pointless).
Ok, so I think we include it in this MR then. Holger -- Sent from /e/ OS on Fairphone3
