Michael Biebl:
> Am 24.03.2017 um 08:31 schrieb Niels Thykier:
>> >From what little I know about meson + ninja, looks fine. The only
>> comment I have is that the ninja file speaks a lot about Makefiles
>> without the code ever touching one. :) Guess it is copy-waste
>> left-overs from make.pm?
>
> Yeah, thanks for spotting. I fixed that.
>
> I've also added a couple of notes/TODOs to the code
>
> a/ Add support for DEB_BUILD_OPTIONS="parallel=N"?
> By default ninja runs N jobs in parallel, where N is derived
> from the number of CPUs.
Should be trivial to do with :
unshift @_, "-j" . (
$this->get_parallel() > 0 ?
$this->get_parallel() : ""
);
> [...]
>
> b/ Add support for DH_QUIET, i.e. don't run with ninja -v in quiet mode.
>
> c/ The install target mangles $ENV to set DESTDIR, which is a bit meh.
> Should we save and restore $ENV?
>
Nope, don't bother. Most debhelper scripts don't do this either (see
e.g. perl_maker.pm)
> Input welcome.
>
>> Re: cross-build, Helmut is usually my goto person for that. Admittedly,
>> he usually contacts me when he discovers an issue. Anyway, per above, I
>> have BCC'ed him, so he at least knows about this work. :)
>
> In theory, meson does support cross building
> https://github.com/mesonbuild/meson/wiki/Cross-compilation
>
> I personally do not have experience with it though. So I would need help
> with implementing that or leave that to someone else. I wouldn't make
> this a blocker though, for merging meson/ninja support.
>
> Regards,
> Michael
>
Indeed, not a blocker.
Thanks,
~Niels
