Am 25.03.2017 um 09:34 schrieb Niels Thykier: > Michael Biebl: >> Am 24.03.2017 um 08:31 schrieb Niels Thykier: >>> >From what little I know about meson + ninja, looks fine. The only >>> comment I have is that the ninja file speaks a lot about Makefiles >>> without the code ever touching one. :) Guess it is copy-waste >>> left-overs from make.pm? >> >> Yeah, thanks for spotting. I fixed that. >> >> I've also added a couple of notes/TODOs to the code >> >> a/ Add support for DEB_BUILD_OPTIONS="parallel=N"? >> By default ninja runs N jobs in parallel, where N is derived >> from the number of CPUs. > > Should be trivial to do with : > > unshift @_, "-j" . ( > $this->get_parallel() > 0 ? > $this->get_parallel() : "" > ); > > >> [...] >> >> b/ Add support for DH_QUIET, i.e. don't run with ninja -v in quiet mode. >> >> c/ The install target mangles $ENV to set DESTDIR, which is a bit meh. >> Should we save and restore $ENV? >> > > Nope, don't bother. Most debhelper scripts don't do this either (see > e.g. perl_maker.pm) >
I've addressed those issues, thanks for your help, Niels. Aside from cross-build support and the autoreconf issue, I consider the current state in biebl/meson usable enough to be merged. I would squash the individual commits and write a proper commit log if you are happy with the code. Regards, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
