On Fri, May 02, 2014 at 09:07:05PM -0700, Cameron Norman wrote: > Dimitri,
> Your special casing of force-reload assumes the init script would have
> put the action in the same boat as reload. Perusing through my
> installed packages, force-reload is often paired with restart instead.
> I am not saying you should change it (restarting is the more
> disruptive action, so doing it when reload is the actual desire is
> bad), but the user should definitely be told what was assumed to be
> their request.
force-reload is defined as:
`force-reload'
cause the configuration to be reloaded if the service supports
this, otherwise restart the service.
So, force-reload *guarantees* that the service configuration is reloaded,
either by doing a soft reload if this is supported, or by restarting the
service if not supported.
We cannot know whether 'reload $service' will cause the configuration to
actually be reloaded for the upstart job in question, so this mapping does
not fulfill the guarantee that the configuration will be reloaded.
Therefore, 'force-reload' must be mapped to 'restart' instead.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: Digital signature
