Hi Cameron,

On Fri, May 02, 2014 at 06:35:30PM -0700, Cameron Norman wrote:
> Hey Steve,

> Is there anything wrong with the script attached by Dimitri ( to
> implement the no-op init script functionality mandated by policy)? If
> not, would you like me to create a deb diff to add the script to the
> appropriate directory?

Actually, this bug report had fallen off my radar.  I had been expecting
Dimitri to implement this in Ubuntu, and that I would cherry-pick it back
into Debian.  Dimitri, is this patch current, and do you want it included
as-is?  I seem to recall some discussion about making the init scripts
pass-through to upstart rather than making them silently fail; did that
discussion reach a conclusion?

Assuming we're ok with the behavior provided by this patch, the only thing I
would change is to check for the existence of the upstart job first, before
checking whether init_is_upstart, since it's the cheaper operation.

Also, why the check for /etc/init/foo.conf as a symlink?  Is that because
upstart doesn't follow symlinks for .conf?

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org

Attachment: signature.asc
Description: Digital signature

Reply via email to