Your message dated Tue, 01 Nov 2022 21:05:36 +0000
with message-id <e1opys0-00gocm...@fasolo.debian.org>
and subject line Bug#977832: fixed in fai 6.0~alpha19
has caused the Debian Bug report #977832,
regarding fai-setup-storage: setup-storage fails if old disk setup contains a
VG with plus sign in its name
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
977832: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977832
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.9.4
Severity: normal
Dear Maintainer,
setup-storage fails to setup a disk if the disk already contains a VG with a
plus sign in its name.
Minimized disk setup that causes the issue:
```
$ parted --script /dev/loop0 print free
Model: Loopback device (loopback)
Disk /dev/loop2: 128MB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags:
Number Start End Size File system Name Flags
1 17.4kB 128MB 128MB primary lvm
$ lsblk /dev/loop0
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
loop2 7:2 0 122.1M 0 loop
└─loop2p1 259:7 0 122M 0 part
└─old_vg-a+b 253:5 0 120M 0 lvm
```
Minimized disk config that reproduces the issue:
```
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
```
The setup-storage error message I get for this combination:
```
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b
-- system left untouched.
```
The impact is that setup-storage can't resetup the disk.
If I remove the `+` from `a+b` then the issue doesn't happen.
If I remove the `disk_config lvm` line then the issue doesn't happen.
We've encountered this issue with existing machines that have been previously
installed with Debian Installer.
Best,
Michael Schaller
setup-storage debug output:
```
disklist: loop0
Starting setup-storage 2.3
Using config file: <redacted>
Input was:
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
(CMD) parted -s /dev/loop0 unit TiB print 1> /tmp/DawnyWaUqw 2> /tmp/1CdIC7E2lZ
Executing: parted -s /dev/loop0 unit TiB print
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 0.00TiB
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags:
(STDOUT)
(STDOUT) Number Start End Size File system Name Flags
(STDOUT) 1 0.00TiB 0.00TiB 0.00TiB primary lvm
(STDOUT)
(CMD) parted -s /dev/loop0 unit B print free 1> /tmp/6y8bZKl8j9 2>
/tmp/cRw5eJZBPo
Executing: parted -s /dev/loop0 unit B print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 128000000B
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags:
(STDOUT)
(STDOUT) Number Start End Size File system Name Flags
(STDOUT) 1 17408B 127983103B 127965696B primary lvm
(STDOUT)
(CMD) parted -s /dev/loop0 unit chs print free 1> /tmp/JpcgqNuRbJ 2>
/tmp/fAQl87C8ra
Executing: parted -s /dev/loop0 unit chs print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 490,49,1
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) BIOS cylinder,head,sector geometry: 490,255,2. Each cylinder is 261kB.
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags:
(STDOUT)
(STDOUT) Number Start End File system Name Flags
(STDOUT) 1 0,17,0 490,33,0 primary lvm
(STDOUT)
Ignoring volume group: dhcp-100-105-1-216-vg
Current disk layout in %current_config
$VAR1 = {
'/dev/loop0' => {
'sector_size' => '512',
'bios_sectors_per_track' => '2',
'size' => '128000000',
'partitions' => {
'1' => {
'flags' => 'lvm',
'filesystem' => '',
'count_byte' =>
'127965696',
'is_extended' => 0,
'begin_byte' => '17408',
'end_byte' => '127983103'
}
},
'begin_byte' => 0,
'bios_cylinders' => '490',
'bios_heads' => '255',
'disklabel' => 'gpt',
'end_byte' => 127999999
}
};
Current LVM layout in %current_lvm_config
$VAR1 = {
'old_vg' => {
'physical_volumes' => [
'/dev/loop0p1'
],
'size' => '120.000839233398',
'volumes' => {
'a+b' => {
'size' => '120.000839233398'
}
}
}
};
Current RAID layout in %current_raid_config
$VAR1 = {};
Current device tree in %current_dev_children
$VAR1 = {
'VG_old_vg' => [
'/dev/old_vg/a+b'
],
'/dev/loop0p1' => [
'VG_old_vg'
],
'/dev/loop0' => [
'/dev/loop0p1'
]
};
Desired disk layout in %FAI::configs
$VAR1 = {
'VG_--ANY--' => {
'opts_all' => {},
'fstabkey' => 'device'
},
'PHY_/dev/loop0' => {
'partitions' => {
'1' => {
'encrypt' => 0,
'start_byte' =>
1048576,
'mountpoint' => '-',
'filesystem' => '-',
'size' => {
'always_format' => 0,
'extended' => 0,
'eff_size' => 126934528,
'resize'
=> 0,
'range'
=> '126934528-126934528',
'preserve' => 0
},
'mount_options' =>
'-',
'end_byte' =>
127983103
}
},
'bootable' => -1,
'fstabkey' => 'device',
'preserveparts' => 0,
'disklabel' => 'gpt',
'opts_all' => {},
'virtual' => 0
}
};
Desired device tree in %FAI::dev_children
$VAR1 = {
'/dev/loop0' => [
'/dev/loop0p1'
]
};
Erased devices: /dev/loop0p1
Trying to add CMD: true
PRE:
POST: exist_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: vgchange -a y old_vg
PRE:
POST: pre_wipe_old_vg
Trying to add CMD: wipefs -a /dev/old_vg/a+b
PRE: pre_wipe_old_vg,
POST: wipefs_old_vg/a+b
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Trying to add CMD: vgremove old_vg
PRE: vgchange_a_n_VG_old_vg,lv_rm_old_vg/a+b
POST: vg_removed_old_vg
Trying to add CMD: pvremove /dev/loop0p1
PRE: vg_removed_old_vg
POST: pvremove_old_vg
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: pvremove_old_vg
POST: pv_sigs_removed_wipe_/dev/loop0p1_old_vg
Trying to add CMD: true
PRE: pvremove_old_vg,pv_sigs_removed_wipe_/dev/loop0p1_old_vg
POST: pv_sigs_removed_old_vg
Trying to add CMD: true
PRE: vgchange_a_n_VG_old_vg,pv_sigs_removed_old_vg,self_cleared_/dev/old_vg/a+b
POST: self_cleared_VG_old_vg
Trying to add CMD: true
PRE: cleared2_/dev/loop0,exist_/dev/loop0p1
POST: pt_complete_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b
-- system left untouched.
```
--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha19
Done: Thomas Lange <la...@debian.org>
We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 977...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Lange <la...@debian.org> (supplier of updated fai package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 01 Nov 2022 10:35:51 +0100
Source: fai
Binary: fai-client fai-doc fai-nfsroot fai-quickstart fai-server
fai-setup-storage
Architecture: source all
Version: 6.0~alpha19
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <la...@debian.org>
Changed-By: Thomas Lange <la...@debian.org>
Description:
fai-client - Fully Automatic Installation client package
fai-doc - Documentation for FAI
fai-nfsroot - Fully Automatic Installation nfsroot package
fai-quickstart - Fully Automatic Installation quickstart package
fai-server - Fully Automatic Installation server package
fai-setup-storage - automatically prepare storage devices
Closes: 844377 951659 977832 985303 987779 989547 990211 990633 999739 1000572
1005745 1006847 1010593 1010906 1011642 1020976
Changes:
fai (6.0~alpha19) experimental; urgency=low
.
[ Thomas Lange ]
* fai-do-scripts: write output of all scripts to scripts.log,
remove code for old cfengine versions (1 and 2)
* fai-make-nfsroot: drop support for .asc files, use only .gpg
* add autopkgtest
* install_packages: add release=<name>
feature, Closes: #844377, add pacman support
* fetch-basefile: cuse curl instead of lftp, so https is now working
* Commands.pm: special handling of nvme devices, Closes: #999739, quote
variables, Closes: #977832, remove old code need by old version of
mkfs.btrfs and lvcreate
* fai-mk-network: usie iproute commands instead of brctl
* fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
do not kill dhclient, Closes: #987779, drop support for dracut < 049,
patch udev rule of lvm for bullseye, include empty machine-id into
base.tar
* Exec.pm: better error message, Closes: #1005745
* fcopy: handle broken symlinks, Closes: #985303
* fai-chboot: add variable substitution when coping a template, add
option -a
* fai-class: use of .source scripts now emits an error
* fai-kvm: add -M for creating NVMe devices
* fai-mirror: use only first line of bpo in sources.list,
Closes: #1006847, print number of packages inside the mirror
* fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
VGs, deactivate them, Closes: #990633, add option -c, print error if
umount fails, increase number of tries
* fai-cd: set TMPDIR for chroot, Closes: #1000572
* fai-setup: create ECDSA keys
* Fstab.pm: support tmpfs size -, this uses the system default size for
tmpfs, Closes: #951659
* setup-storage: add support for fstabkey:partlabel and
fstabkey:partuuid, remove crypto keyfile after use
* enhance disk_config format for partition label support
* ftar: add support for zstd
* fai: check if unshare can be used, Closes: #989547
use only IPv4 address as hostname
remove code for deprecated taskname prepareapt
* watch: update to version 4, use new url
* install_packages: parse apt-cache output, Closes: #990211
* subroutines: umount tmpfs if config space was downloaded via http,
Closes: #1011642
* task_sysinfo: print machine readable partition information, do not
call commands that modify the system if no run in FAI environment,
print battery information
* subroutines: add help functions:
ctam (Chroot TArget Mount pseudo filesystems)
ctau (Chroot TArget Umount)
ctai (Chroot TArget Into)
rm_target (remount /target read-write)
* NFSROOT: cleanup package list, add cryptsetup
* update my email address
* mk-basefile: remove /var/lib/dbus/machine-id, use zstd instead of gzip
* simple/examples: use fai-link and fai-sed instead of ln and sed,
remove cryptsetup passphrase from logs, use class ROCKY instead of
CENTOS, update Ubuntu support to 22.04, add CLOUD_EFI, use ext4 for
/boot in LVM examples
.
[ Mike Gabriel ]
* fai-abort:give job control to bash, Closes: #1020976
.
[ Juri Grabowski ]
* install_packages: add support for alpine Linux apk and
Archlinux pacman
.
[ Guido Günther ]
* subroutines: allow one to pass a debootstrap script in FAI_DEBOOTSTRAP
.
[ Christian Meyer ]
* fai-setup: add ECDSA-key to known_hosts
.
[ Aki Tuomi ]
* check-cross-arch: fail on errors and unbound variables
.
[ Hannes Eberhardt ]
* package_config/ROCKY: update EFI packages
Checksums-Sha1:
990734efd5a76910f09ca978229f36944932c8ad 2094 fai_6.0~alpha19.dsc
28af02e6b8a3024870d0529c8f7b1fd143ff8ce4 292408 fai_6.0~alpha19.tar.xz
52e78446daced8eead0d0e9690eb9280eee6fe96 156392 fai-client_6.0~alpha19_all.deb
1fdcd05a481190f03ac1ffe55378edcfd01f2883 748972 fai-doc_6.0~alpha19_all.deb
abeb5b2feabacec2a11ca5b66c3f71c984bfc1ef 83012 fai-nfsroot_6.0~alpha19_all.deb
a47d9211b85aa75fbddd4cf5c8b43b92b01463b3 1556
fai-quickstart_6.0~alpha19_all.deb
fb24edb6fcd288b337862819ad9868aed003ce8c 73404 fai-server_6.0~alpha19_all.deb
f67de17d5bcd9ce8bd08dfd77a5679cf3dfbec10 122456
fai-setup-storage_6.0~alpha19_all.deb
6eb2013cd5ad46404b7c2501bfb30d7a8085f299 16335 fai_6.0~alpha19_amd64.buildinfo
Checksums-Sha256:
907c478c8ee5f7b954b17b8d9b157e16789b662fa024d2eac23f8ebaaa90db94 2094
fai_6.0~alpha19.dsc
dc091f151c807659a7a56764c9e0cfca9b4a763d0f50f86caf5aa45204dad524 292408
fai_6.0~alpha19.tar.xz
e7bf853485959dd84ea162282f4ddb2ce588aba7dda12167d07ea7b29aa9ff9f 156392
fai-client_6.0~alpha19_all.deb
427614bb81e8945367642f4162e3e7e5a9666ee52d07aeca450b5a917564b869 748972
fai-doc_6.0~alpha19_all.deb
f9df1d89003760b69085fbe678c64fb89aa768f45b6537e8bdb9dd7eccb79ae5 83012
fai-nfsroot_6.0~alpha19_all.deb
7409ac795eb99d09ae789bb7ff418e2f260bd3197520b67406d1c04f972853cb 1556
fai-quickstart_6.0~alpha19_all.deb
8d307995f6bc01479061afe0c825a1f739a84de64d0f51ea4eaa7ebc18c6b5f3 73404
fai-server_6.0~alpha19_all.deb
954b7c838f168068ce345a052c0105907b5675911a6f73efdbec73f64c475c65 122456
fai-setup-storage_6.0~alpha19_all.deb
e3517752daf186def0ba2489a7cfd5f9decdc3cd90372e02ad90d30f83e2f2cf 16335
fai_6.0~alpha19_amd64.buildinfo
Files:
55c4a4a659e33428d51a96e28f2aec4c 2094 admin optional fai_6.0~alpha19.dsc
a6d8c7aab99a1854535dbb1af0f5f9bb 292408 admin optional fai_6.0~alpha19.tar.xz
e6b6113435d0156d322fcd179c3c34b7 156392 admin optional
fai-client_6.0~alpha19_all.deb
c129233a6cc6935c870389a1c039108b 748972 doc optional
fai-doc_6.0~alpha19_all.deb
656d2e1ba8f2066aa0e771cdb2707a35 83012 admin optional
fai-nfsroot_6.0~alpha19_all.deb
1724a22fcb80115822866f6798913812 1556 admin optional
fai-quickstart_6.0~alpha19_all.deb
aac422aa6fad4244f54bcbd46ade941f 73404 admin optional
fai-server_6.0~alpha19_all.deb
1bc59cf9f6a673918341b63c75fa0263 122456 admin optional
fai-setup-storage_6.0~alpha19_all.deb
33c1fcaee82f1f8a8a55dd920d98e2aa 16335 admin optional
fai_6.0~alpha19_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmNhgs8RHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeRydw/8CCD41DS3TXAzGtQLv5EJkGGYqPz3uYkj
TbWwPcDKG3hBTxrUqAMSTwTlHhHGlAraGgEB7VKRsWgHd4FsIoAPPMiuihdyNO0y
L7tB1cLSYbweoXSEveFaLSWvbByPatV4r5yBMUKoaCG0HB3H6MpRh3kvqTfmcVP2
aqgQp0igRFruvKz14G42cpjGhtxhqDiYYOSkmrUS7u7yEyWPI3HZoZ+77gNMyAha
V1EkwMaJ7ozk8AvCTyS1/nQIpcsGZjirx0OsGe8sX/Sg5ZadzRZRm0/N5vO8HCwP
4t39Dky3+lIICJAZQC2eOso7gISPLgcViC58LuXipOLW+b1FZn7HnzxklbEe52LD
DmbdbSV5xVaoMUQQ5fsNSd/vp7gIyzEKkzhvJgXvR942B3fyXrv0qL+bfUvPg2ub
W1mKYX1S+l4zDwGLhGdmwfTUnS7DKtpy0zyhlwRe1ljB65ZXWATG/7wpQfLydrGh
zfuP/nPteBRtkwLiPS8bqOPAW90AhPwwV/6dgo+iRPrZojdJatTuCmdKvuthKjkH
/aFBh6pMKsBF8H91U8RCTIpklgnBJqbKn8H5zf5n9xHGsR78G+0CXXirbwhNAbJk
/k4lqGjvyn7wr11CfFnocjsirn8MXmc2mjajujFNcLczz1jUM3mXn+VkbZXEbJxm
+5K9TqSMVkA=
=gqiP
-----END PGP SIGNATURE-----
--- End Message ---
