Your message dated Tue, 01 Nov 2022 09:49:31 +0000
with message-id <e1opntj-00dkhj...@fasolo.debian.org>
and subject line Bug#977832: fixed in fai 6.0~alpha18
has caused the Debian Bug report #977832,
regarding fai-setup-storage: setup-storage fails if old disk setup contains a
VG with plus sign in its name
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
977832: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977832
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.9.4
Severity: normal
Dear Maintainer,
setup-storage fails to setup a disk if the disk already contains a VG with a
plus sign in its name.
Minimized disk setup that causes the issue:
```
$ parted --script /dev/loop0 print free
Model: Loopback device (loopback)
Disk /dev/loop2: 128MB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags:
Number Start End Size File system Name Flags
1 17.4kB 128MB 128MB primary lvm
$ lsblk /dev/loop0
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
loop2 7:2 0 122.1M 0 loop
└─loop2p1 259:7 0 122M 0 part
└─old_vg-a+b 253:5 0 120M 0 lvm
```
Minimized disk config that reproduces the issue:
```
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
```
The setup-storage error message I get for this combination:
```
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b
-- system left untouched.
```
The impact is that setup-storage can't resetup the disk.
If I remove the `+` from `a+b` then the issue doesn't happen.
If I remove the `disk_config lvm` line then the issue doesn't happen.
We've encountered this issue with existing machines that have been previously
installed with Debian Installer.
Best,
Michael Schaller
setup-storage debug output:
```
disklist: loop0
Starting setup-storage 2.3
Using config file: <redacted>
Input was:
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
(CMD) parted -s /dev/loop0 unit TiB print 1> /tmp/DawnyWaUqw 2> /tmp/1CdIC7E2lZ
Executing: parted -s /dev/loop0 unit TiB print
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 0.00TiB
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags:
(STDOUT)
(STDOUT) Number Start End Size File system Name Flags
(STDOUT) 1 0.00TiB 0.00TiB 0.00TiB primary lvm
(STDOUT)
(CMD) parted -s /dev/loop0 unit B print free 1> /tmp/6y8bZKl8j9 2>
/tmp/cRw5eJZBPo
Executing: parted -s /dev/loop0 unit B print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 128000000B
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags:
(STDOUT)
(STDOUT) Number Start End Size File system Name Flags
(STDOUT) 1 17408B 127983103B 127965696B primary lvm
(STDOUT)
(CMD) parted -s /dev/loop0 unit chs print free 1> /tmp/JpcgqNuRbJ 2>
/tmp/fAQl87C8ra
Executing: parted -s /dev/loop0 unit chs print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 490,49,1
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) BIOS cylinder,head,sector geometry: 490,255,2. Each cylinder is 261kB.
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags:
(STDOUT)
(STDOUT) Number Start End File system Name Flags
(STDOUT) 1 0,17,0 490,33,0 primary lvm
(STDOUT)
Ignoring volume group: dhcp-100-105-1-216-vg
Current disk layout in %current_config
$VAR1 = {
'/dev/loop0' => {
'sector_size' => '512',
'bios_sectors_per_track' => '2',
'size' => '128000000',
'partitions' => {
'1' => {
'flags' => 'lvm',
'filesystem' => '',
'count_byte' =>
'127965696',
'is_extended' => 0,
'begin_byte' => '17408',
'end_byte' => '127983103'
}
},
'begin_byte' => 0,
'bios_cylinders' => '490',
'bios_heads' => '255',
'disklabel' => 'gpt',
'end_byte' => 127999999
}
};
Current LVM layout in %current_lvm_config
$VAR1 = {
'old_vg' => {
'physical_volumes' => [
'/dev/loop0p1'
],
'size' => '120.000839233398',
'volumes' => {
'a+b' => {
'size' => '120.000839233398'
}
}
}
};
Current RAID layout in %current_raid_config
$VAR1 = {};
Current device tree in %current_dev_children
$VAR1 = {
'VG_old_vg' => [
'/dev/old_vg/a+b'
],
'/dev/loop0p1' => [
'VG_old_vg'
],
'/dev/loop0' => [
'/dev/loop0p1'
]
};
Desired disk layout in %FAI::configs
$VAR1 = {
'VG_--ANY--' => {
'opts_all' => {},
'fstabkey' => 'device'
},
'PHY_/dev/loop0' => {
'partitions' => {
'1' => {
'encrypt' => 0,
'start_byte' =>
1048576,
'mountpoint' => '-',
'filesystem' => '-',
'size' => {
'always_format' => 0,
'extended' => 0,
'eff_size' => 126934528,
'resize'
=> 0,
'range'
=> '126934528-126934528',
'preserve' => 0
},
'mount_options' =>
'-',
'end_byte' =>
127983103
}
},
'bootable' => -1,
'fstabkey' => 'device',
'preserveparts' => 0,
'disklabel' => 'gpt',
'opts_all' => {},
'virtual' => 0
}
};
Desired device tree in %FAI::dev_children
$VAR1 = {
'/dev/loop0' => [
'/dev/loop0p1'
]
};
Erased devices: /dev/loop0p1
Trying to add CMD: true
PRE:
POST: exist_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: vgchange -a y old_vg
PRE:
POST: pre_wipe_old_vg
Trying to add CMD: wipefs -a /dev/old_vg/a+b
PRE: pre_wipe_old_vg,
POST: wipefs_old_vg/a+b
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Trying to add CMD: vgremove old_vg
PRE: vgchange_a_n_VG_old_vg,lv_rm_old_vg/a+b
POST: vg_removed_old_vg
Trying to add CMD: pvremove /dev/loop0p1
PRE: vg_removed_old_vg
POST: pvremove_old_vg
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: pvremove_old_vg
POST: pv_sigs_removed_wipe_/dev/loop0p1_old_vg
Trying to add CMD: true
PRE: pvremove_old_vg,pv_sigs_removed_wipe_/dev/loop0p1_old_vg
POST: pv_sigs_removed_old_vg
Trying to add CMD: true
PRE: vgchange_a_n_VG_old_vg,pv_sigs_removed_old_vg,self_cleared_/dev/old_vg/a+b
POST: self_cleared_VG_old_vg
Trying to add CMD: true
PRE: cleared2_/dev/loop0,exist_/dev/loop0p1
POST: pt_complete_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b
-- system left untouched.
```
--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha18
Done: Thomas Lange <la...@debian.org>
We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 977...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Lange <la...@debian.org> (supplier of updated fai package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 01 Nov 2022 10:35:51 +0100
Source: fai
Architecture: source
Version: 6.0~alpha18
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <la...@debian.org>
Changed-By: Thomas Lange <la...@debian.org>
Closes: 844377 951659 977832 985303 987779 989547 990211 990633 999739 1000572
1005745 1006847 1010593 1010906 1011642 1020976
Changes:
fai (6.0~alpha18) experimental; urgency=low
.
[ Thomas Lange ]
* fai-do-scripts: write output of all scripts to scripts.log,
remove code for old cfengine versions (1 and 2)
* fai-make-nfsroot: drop support for .asc files, use only .gpg
* add autopkgtest
* install_packages: add release=<name>
feature, Closes: #844377, add pacman support
* fetch-basefile: cuse curl instead of lftp, so https is now working
* Commands.pm: special handling of nvme devices, Closes: #999739, quote
variables, Closes: #977832, remove old code need by old version of
mkfs.btrfs and lvcreate
* fai-mk-network: usie iproute commands instead of brctl
* fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
do not kill dhclient, Closes: #987779, drop support for dracut < 049,
patch udev rule of lvm for bullseye, include empty machine-id into
base.tar
* Exec.pm: better error message, Closes: #1005745
* fcopy: handle broken symlinks, Closes: #985303
* fai-chboot: add variable substitution when coping a template, add
option -a
* fai-class: use of .source scripts now emits an error
* fai-kvm: add -M for creating NVMe devices
* fai-mirror: use only first line of bpo in sources.list,
Closes: #1006847, print number of packages inside the mirror
* fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
VGs, deactivate them, Closes: #990633, add option -c, print error if
umount fails, increase number of tries
* fai-cd: set TMPDIR for chroot, Closes: #1000572
* fai-setup: create ECDSA keys
* Fstab.pm: support tmpfs size -, this uses the system default size for
tmpfs, Closes: #951659
* setup-storage: add support for fstabkey:partlabel and
fstabkey:partuuid, remove crypto keyfile after use
* enhance disk_config format for partition label support
* ftar: add support for zstd
* fai: check if unshare can be used, Closes: #989547
use only IPv4 address as hostname
remove code for deprecated taskname prepareapt
* watch: update to version 4, use new url
* install_packages: parse apt-cache output, Closes: #990211
* subroutines: umount tmpfs if config space was downloaded via http,
Closes: #1011642
* task_sysinfo: print machine readable partition information, do not
call commands that modify the system if no run in FAI environment,
print battery information
* subroutines: add help functions:
ctam (Chroot TArget Mount pseudo filesystems)
ctau (Chroot TArget Umount)
ctai (Chroot TArget Into)
rm_target (remount /target read-write)
* NFSROOT: cleanup package list, add cryptsetup
* update my email address
* mk-basefile: remove /var/lib/dbus/machine-id, use zstd instead of gzip
* simple/examples: use fai-link and fai-sed instead of ln and sed,
remove cryptsetup passphrase from logs, use class ROCKY instead of
CENTOS, update Ubuntu support to 22.04, add CLOUD_EFI, use ext4 for
/boot in LVM examples
.
[ Mike Gabriel ]
* fai-abort:give job control to bash, Closes: #1020976
.
[ Juri Grabowski ]
* install_packages: add support for alpine Linux apk and
Archlinux pacman
.
[ Guido Günther ]
* subroutines: allow one to pass a debootstrap script in FAI_DEBOOTSTRAP
.
[ Christian Meyer ]
* fai-setup: add ECDSA-key to known_hosts
.
[ Aki Tuomi ]
* check-cross-arch: fail on errors and unbound variables
.
[ Hannes Eberhardt ]
* package_config/ROCKY: update EFI packages
Checksums-Sha1:
f35ce0cdc3b619cee939112909b0d815e379bab2 2094 fai_6.0~alpha18.dsc
674b1c7b65b723598428a5a954fb7a7fb1c0c3bf 292264 fai_6.0~alpha18.tar.xz
db9ff332f9084be24ae96dc441c4d72398a6f0bc 16335 fai_6.0~alpha18_amd64.buildinfo
Checksums-Sha256:
a2eeee10af04b9d54ac49c577fae929528f74bb98bb2943ab90e7ffa5e07d0e1 2094
fai_6.0~alpha18.dsc
9263d1be261d7147bae2cb3d3228adcd7e7dcdca95202cae37bc46be50178f6e 292264
fai_6.0~alpha18.tar.xz
3a046f05121684b5fc9adb81013c693ddf79c07ae742eb205e9f06d1dfce3862 16335
fai_6.0~alpha18_amd64.buildinfo
Files:
67980243672e5f65ace8dc6d4df9a1a1 2094 admin optional fai_6.0~alpha18.dsc
19e58cf92d99a2a8a2dfbd20a3b41f35 292264 admin optional fai_6.0~alpha18.tar.xz
c05b71d8da267f1fae911ae50da1c006 16335 admin optional
fai_6.0~alpha18_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmNg6OoRHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeRWwQ//cfqMYM9nvYi7TrPkck/hdJrJd8dU84RR
8VUNjviCsqQ7/b4foSD7//qXk/o6GhlVEUgzAlHUM3En5cjvywuB4aNT95ta47lr
35wvRpO5LMvOXt2uE5q5GC98vELNoXezQW4S9JziUzqUgVR2x519kFJGQwQx/2Vg
JU3Z5U4mH06K+5qKs+s/9wgvjC4o/lCdGNql1dIn+nsrGE+ICRVEBEsecr2PbNtV
rBPImjeNcqnLruUcy3V1lvPQblPo0g8EhBS3r3moYm+gMsXKP3IoL7ElK+jlNqN6
FCx3tCwdbev6rt2ZeGaqzaUwagh2UzvQlHZg2gdSteWp5CmDQDwmwRr4qtYA5XfW
9xQSFUvGL12DuGzna/W9wrYysEdpUsWZMv8o75m0w/zewaXYmNZX6D92pIq/fLX9
L1x8Xth3qPP3VxmA99uGYJZrosA+DEWxMJ6KBwrnw179TxA9cM0GyQL0BozGF3u3
Ci17FRXuCH0LnZIlRoo7PVsQcUHmWCOrcyZsErimO8J5Exu3IbJVAPMUt5FVkAXn
8bbCp7It3feEUsE//w7y3J/fI+AMDFVAzU732U67v+Z7ZevvXQo5b9NtIEPW+vau
lWaS/BHNOt8wlMz36zfZeTP4q3H380EIMj3QskytOZRfaLpHUB2zBwMTgj2bGIhT
zTPKe4nhEH0=
=gvM2
-----END PGP SIGNATURE-----
--- End Message ---