On Mon, 7 Jul 2025 12:58:39 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> This mostly just adds overrides to the wrapper implementations in >> java.util.Collections. However, in order to satisfy the test, some overrides >> are also added to ReverseOrderSortedMapView, which is used by the SortedMap >> wrapper keySet, values, and entrySet views. These overrides don't do >> anything except to call super, so they're arguably dead code. However, they >> enable all combinations of sequenced map views to be tested, which is >> valuable. > > src/java.base/share/classes/java/util/Collections.java line 2768: > >> 2766: } >> 2767: } >> 2768: > > Is this `SynchronizedNavigableSet` missing overrides for the > `addFirst/addLast/removeFirst/removeLast/getFirst/getLast` default methods? Maybe not, because this extends the nearby `SynchronizedSortedSet` which has the overridden default methods. Would it still be worth considering overriding those here too? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25478#discussion_r2190014774
