On Wed, 28 May 2025 03:03:45 GMT, Stuart Marks <sma...@openjdk.org> wrote:

> This mostly just adds overrides to the wrapper implementations in 
> java.util.Collections. However, in order to satisfy the test, some overrides 
> are also added to ReverseOrderSortedMapView, which is used by the SortedMap 
> wrapper keySet, values, and entrySet views. These overrides don't do anything 
> except to call super, so they're arguably dead code. However, they enable all 
> combinations of sequenced map views to be tested, which is valuable.

src/java.base/share/classes/java/util/Collections.java line 1052:

> 1050:      * are intended to override but are declared improperly will be 
> detected through testing.
> 1051:      * (The @Override annotation still occurs in several places in this 
> file. These will be
> 1052:      * removed over time.)

Nit - The last sentence, I think, isn't necessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25478#discussion_r2189932047

Reply via email to