Hean-Chhinling commented on code in PR #8641:
URL: https://github.com/apache/hadoop/pull/8641#discussion_r3729685119
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerConfigValidator.java:
##########
@@ -735,4 +736,96 @@ private CapacitySchedulerConfiguration
setupCSConfiguration(YarnConfiguration co
return csConf;
}
+
+ private static final String ACCESSIBLE_LABELS_CAPACITY_ERROR =
Review Comment:
Hmm...I am not sure that I understand you. I created a constant here for the
error message to avoid duplication when checking for error message many times
in the test.
But at CapacitySchedulerConfigValidator, the exception is thrown only one so
I do not think creating a constant there for the error message would be a good
idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
