Hean-Chhinling commented on PR #8641:
URL: https://github.com/apache/hadoop/pull/8641#issuecomment-5156779518

   > Thanks @Hean-Chhinling for taking care of this issue!
   > 
   > If i understand correctly with the mutable conf api the users can creates 
capacity configs what will be invalid. In that case, this validation should 
happen in the `CapacitySchedulerConfigValidator` at the first place. This UI 
validation also can be useful.
   > 
   > May i ask you to attach some screenshot to the jira ticket how the manual 
test happened?
   
   You are right @K0K0V0K!
   I should have stopped the misconfiguration from the backend not just at the 
UI.
   I will update the code in my new commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to