Hean-Chhinling commented on code in PR #8641:
URL: https://github.com/apache/hadoop/pull/8641#discussion_r3740543040
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerQueueManager.java:
##########
@@ -201,6 +201,7 @@ public void
reinitializeQueues(CapacitySchedulerConfiguration newConf)
// Ensure queue hierarchy in the new XML file is proper.
CapacitySchedulerConfigValidator
.validateQueueHierarchy(queues, newQueues, newConf);
+ CapacitySchedulerConfigValidator.validateQueueAccessibleLabels(newConf);
Review Comment:
Nice catch @K0K0V0K.
I tested it and confirmed your theory. I was able to start up with an
invalid configuration but when I edit the capacity it throws the 400 error. I
will add my validation to `CapacityScheduler.validateConf` in my next commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
