brumi1024 commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1083821014
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java:
##########
@@ -194,6 +199,10 @@ public void testDefaultUserLimitFactor() throws Exception {
assertNull("root.users user-limit-factor should be null",
conf.get(PREFIX + "root.users." + USER_LIMIT_FACTOR));
+ assertEquals("root.users auto-queue-creation-v2.enabled", "true",
+ conf.get(PREFIX + "root.users.auto-queue-creation-v2.enabled"));
+ assertNull( "root.users auto-create-child-queue.enabled should be null",
+ conf.get(PREFIX + "root.users.auto-create-child-queue.enabled"));
Review Comment:
Yes please. The basic purpose of a test like this would be to check if the
auto-create-child-queue.enabled is true the user-limit-factor = -1 isn't added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
