brumi1024 commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1063534266
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java:
##########
@@ -309,6 +311,11 @@ private void checkMaxChildCapacitySetting(FSQueue queue) {
}
}
+ private boolean checkAutoQueueCreationV2Disabled(String queueName) {
+ return !Objects.equals(capacitySchedulerConfig.get(
+ PREFIX + queueName + DOT + AUTO_QUEUE_CREATION_V2_ENABLED), "true");
Review Comment:
This won't return true because Object.equals only returns true if both of
the compared objects refer to the same object, String.equals compares the
values themselves. But CapacitySchedulerConfiguration already has a helper
method which parses the value to a boolean, so I suggest using that. See
isAutoQueueCreationV2Enabled.
Also if percentage mode is used when converting it'll have the legacy Auto
Queue Creation property, which too has a helper method, called
isAutoCreateChildQueueEnabled. Both of these should be checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
