susheel-gupta commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1071075406
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java:
##########
@@ -194,6 +199,10 @@ public void testDefaultUserLimitFactor() throws Exception {
assertNull("root.users user-limit-factor should be null",
conf.get(PREFIX + "root.users." + USER_LIMIT_FACTOR));
+ assertEquals("root.users auto-queue-creation-v2.enabled", "true",
+ conf.get(PREFIX + "root.users.auto-queue-creation-v2.enabled"));
+ assertNull( "root.users auto-create-child-queue.enabled should be null",
+ conf.get(PREFIX + "root.users.auto-create-child-queue.enabled"));
Review Comment:
In class TestFSQueueConverter, there is method
testQueueWithNoAutoCreateChildQueue which checks assert
.auto-create-child-queue.enabled to null but according to above comment I need
to add a property of auto-create-child-queue.enabled to true.
So do I need to add a another set of queues where
auto-create-child-queue.enabled is true or is this check of
checkAutoCreateChildQueueDisabled really required?.
```
testQueueWithNoAutoCreateChildQueue() {
converter = builder
.withCapacitySchedulerConfig(csConfig)
.build();
converter.convertQueueHierarchy(rootQueue);
assertNoValueForQueues(ALL_QUEUES, ".auto-create-child-queue.enabled",
csConfig);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
