lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage
of commonPool in RatisPipelineUtils.
URL: https://github.com/apache/hadoop/pull/714#discussion_r284615716
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
##########
@@ -346,6 +347,11 @@ public void triggerPipelineCreation() {
backgroundPipelineCreator.triggerPipelineCreation();
}
+ @Override
+ public PipelineFactory getPipelineFactory() {
Review comment:
We dont need to expose this api. We can add a shutdown call for the
pipelineFactory in the SCMPipelineManager#close fn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
